Skip to content

File gets included twice when composes a file directly and indirectly #155

Closed

Description

@madpilot

The scenario is this:

file a composes a selector from file c and b (in that order)
file b composes a selector from file c

the output includes the source from file c twice (and in an order where the second inclusion will override the selector from b).

I have a failing test case here: https://github.com/madpilot/css-modules-loader-core/tree/master/test/test-cases/mixed-dependencies

Activity

  1. joshwnj commented on Aug 19, 2016

    @joshwnj
    Member

    @madpilot out of interest, does this kind of thing appear to get picked up by any of the postcss optimizers (csso, cssnano)?

  2. madpilot commented on Aug 19, 2016

    @madpilot
    Author

    I haven't tried - I say it would...

    I'm looking at it now, I think I have a solution but it looks like it breaks ordering

  3. joshwnj commented on Aug 19, 2016

    @joshwnj
    Member

    lol even I forgot I did this: #62

  4. joshwnj commented on Aug 19, 2016

    @joshwnj
    Member

    @madpilot css-modules-loader-core@1.0.1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions