Skip to content

Simplify releases to build the current official PHP images - #67

Merged
baschny merged 1 commit into
masterfrom
simplify-release-pipeline
Oct 21, 2026
Merged

baschny merged 1 commit into
masterfrom
simplify-release-pipeline

Conversation

@baschny

@baschny baschny commented Oct 21, 2026

Copy link
Copy Markdown
Member

Releases are triggered by hand once the official images are up to date. Automatically discovering and verifying upstream versions added a lot of machinery and broke the first real publish run, so this PR removes it (+78 / −700 lines).

Removed

  • scripts/resolve-bases.py, tests/test_resolve_bases.py and .github/workflows/resolve-bases.yml: php.net release discovery, waiting up to an hour for upstream images, pinning base images to exact digests, comparing patch versions across architectures, and skipping unsupported versions.
  • The PHP_BASE_IMAGE / EXPECTED_PHP_VERSION plumbing in the Dockerfile, docker-bake.hcl, the Makefile, tests/smoke.sh and the workflows, plus make test-resolver.
  • The second build export with config-digest verification and the digest artifacts. That check failed every job in publish run 39655891018: buildx omits containerimage.config.digest when attestations turn the pushed image into an index, although the pushed candidates were identical to the tested images.

How it works now

  • Both workflows read the matrix directly from build-versions.json, and builds use php:X.Y-fpm as published.
  • Each native AMD64/ARM64 job builds, loads and smoke-tests both images, then adds a PHP/Node version table to its job summary for the manual check.
  • On manual publish from master, each job docker pushes exactly the images it tested to build-<run id>-…-<arch> candidate tags. Once all jobs pass, imagetools create merges them into the public php-X.Y and php-X.Y-node-N tags. Rerunning only failed jobs reuses the candidates pushed earlier in the same run.
  • Unchanged: native runners, smoke tests, manual-only publishing from master, PR builds without secrets, Bake/cache setup, the install retry.

Trade-off: pushed images no longer carry the provenance attestations that buildx attached in the removed export step.

Validation

  • actionlint (rhysd/actionlint 1.7.7) on all workflows, make check, docker buildx bake --print.
  • make build test PHP_VERSION=8.5 NODE_VERSION=26 passes locally. The summary step was run locally and prints PHP 8.5.12 / Node v26.12.1.
  • Pushing a loaded image to a local registry and running docker buildx imagetools create on it produced a manifest list with the correct linux/arm64 platform entry.
  • PR CI covers the build and test path. The push and manifest steps only run in a manual publish from master after merge.

🤖 Generated with Claude Code

Drop the base-image resolver: php.net release discovery, waiting for
upstream images, immutable digest pinning, cross-architecture patch
comparison, expected-version checks and their unit tests. Releases are
triggered manually once the official images are up to date, so builds
use php:X.Y-fpm as published.

Publishing now pushes the exact images that passed the smoke tests to
per-run candidate tags and merges them into the public tags, instead
of re-exporting the build and comparing digests. Each build job lists
its PHP and Node versions in the job summary for a manual check.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
@baschny
baschny merged commit d7be4a3 into master Oct 21, 2026
9 checks passed
@baschny
baschny deleted the simplify-release-pipeline branch October 21, 2026 23:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant