Repository navigation
Simplify releases to build the current official PHP images - #67
Merged
Merged
Conversation
Drop the base-image resolver: php.net release discovery, waiting for upstream images, immutable digest pinning, cross-architecture patch comparison, expected-version checks and their unit tests. Releases are triggered manually once the official images are up to date, so builds use php:X.Y-fpm as published. Publishing now pushes the exact images that passed the smoke tests to per-run candidate tags and merges them into the public tags, instead of re-exporting the build and comparing digests. Each build job lists its PHP and Node versions in the job summary for a manual check. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Releases are triggered by hand once the official images are up to date. Automatically discovering and verifying upstream versions added a lot of machinery and broke the first real publish run, so this PR removes it (+78 / −700 lines).
Removed
scripts/resolve-bases.py,tests/test_resolve_bases.pyand.github/workflows/resolve-bases.yml: php.net release discovery, waiting up to an hour for upstream images, pinning base images to exact digests, comparing patch versions across architectures, and skipping unsupported versions.PHP_BASE_IMAGE/EXPECTED_PHP_VERSIONplumbing in the Dockerfile,docker-bake.hcl, the Makefile,tests/smoke.shand the workflows, plusmake test-resolver.containerimage.config.digestwhen attestations turn the pushed image into an index, although the pushed candidates were identical to the tested images.How it works now
build-versions.json, and builds usephp:X.Y-fpmas published.master, each jobdocker pushes exactly the images it tested tobuild-<run id>-…-<arch>candidate tags. Once all jobs pass,imagetools createmerges them into the publicphp-X.Yandphp-X.Y-node-Ntags. Rerunning only failed jobs reuses the candidates pushed earlier in the same run.master, PR builds without secrets, Bake/cache setup, the install retry.Trade-off: pushed images no longer carry the provenance attestations that buildx attached in the removed export step.
Validation
make check,docker buildx bake --print.make build test PHP_VERSION=8.5 NODE_VERSION=26passes locally. The summary step was run locally and prints PHP 8.5.12 / Node v26.12.1.docker buildx imagetools createon it produced a manifest list with the correctlinux/arm64platform entry.masterafter merge.🤖 Generated with Claude Code