Repository navigation
Discover announced PHP patches for manual releases - #66
Merged
Merged
Conversation
Typing an expected-version JSON map for every security release was error-prone and blocked on someone reading the announcement. Release runs now read the latest patch of each configured branch from php.net, skip branches php.net no longer supports, and wait up to an hour for the official Docker images to carry those exact patches on AMD64 and ARM64. Missing or invalid release metadata fails preparation instead of falling back to an older base image.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
Releasing patched images for a PHP security update (like today's 8.4.27 / 8.3.36 / 8.2.35) meant reading the announcement and typing an
expected-versionsJSON map into the workflow. That was error-prone and the release couldn't start until someone had done it.What changes
--latest-releases) reads the latest patch for each configured branch from php.net's release JSON.--wait-seconds 3600, job timeout 75 min) for the officialphp:X.Y-fpmimages to have the announced patch on both AMD64 and ARM64, then pins the base digests for the rest of the run.build-only.ymldrops its optionalexpected-versionsinput.Validation
make test-resolver: 26 tests pass, 13 of them new (php.net discovery, EOL skip, network failures, bounded wait/timeout)..github/workflows/*.yml: clean.python3 scripts/resolve-bases.py --latest-releasesresolved 8.4.27, 8.3.36 and 8.2.35 on AMD64 + ARM64 and skipped 8.1.Note
pecl.php.net is currently returning intermittent 500/504 errors, which also breaks image builds (see #65). PR CI may fail for that reason, not because of this change.
🤖 Generated with Claude Code