Repository navigation
Add Mat22 reflection and shear constructors - #63
Merged
Merged
Conversation
1 similar comment
This was referenced Sep 16, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds
Mat22.make_reflect/1,make_shear_x/1, andmake_shear_y/1for 2D linear transformations, using the library's row-vector convention.Reflection accepts any nonzero normal and mirrors across the line through the origin. Normal scaling avoids overflow or underflow from squaring very large or small normals; a zero normal raises
ArithmeticError. Shear docs state which coordinate changes and give its equation. All constructors retain float typespecs and explicit float clauses with numeric fallbacks.Validation: 494 tests and 1 doctest pass with 100% line coverage. Tests cover axis and oblique mirrors, normal scaling, reflection invariants, both shear directions, inverses, composition order, and integer/mixed inputs. Formatting, compilation with warnings as errors, and documentation generation pass.
Part of #44.