Repository navigation
Conversation
2 similar comments
This was referenced Sep 16, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add
Graphmath.Vec4with four-component constructors, arithmetic, dot products, norms, normalization, interpolation, projection, and comparisons. Float typespecs and float-specialized clauses follow the existing vector modules, with numeric fallbacks and direct tuple arithmetic.from_point3/1andfrom_direction3/1make homogeneous intent explicit by settingwto 1.0 and 0.0. Docs and tests show that Mat44 translation moves points while leaving directions unchanged, and explain that four-dimensional normalization is distinct from dividing by the homogeneous coordinate.Part of #44.
Validation: 26 new tagged tests and 2 doctests cover integer/float/mixed inputs, all four components, independent arithmetic results, equality/distance boundaries, zero errors, and homogeneous point/direction behavior. The full suite passes with 511 tests and 3 doctests, and library coverage remains 100%. Formatting, warnings-as-errors compilation, documentation generation, and diff checks pass.