Repository navigation
CMake: Adding full CMake support for building and testing - #7
Merged
Merged
Conversation
qknight
force-pushed
the
cmake_adding_support
branch
from
July 15, 2021 07:11
5f5cbb2 to
4db1714
Compare
Open
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR is adding full CMake support. The only thing left do do is to figure out why 3 of the tests fail:
Motivation
We want to be able to do our of source builds and since we use lots of CMake already this was the only submodule which still forced us to Makefiles.
Also we can now use ninja to build all our source code.
It is now easy to include this code base using CMakeLists.txt from the parent:
add_subdirectory(libs/gherkin-cpp)
link_libraries(PUBLIC gherkin-cpp::gherkin-cpp)
The
link_librarieswill then also add the headers to the search path.Tests
What test(s) still fail:
All other work! But I think that I did not cause those fails. Probably the tests need updates...