Skip to content

Error with Jan 21, 2017 C++17 bugfix #7

Closed

Description

@GeoffHadlington

The bugfix to allow the use of the std::optional function from c++17 doesn't compile when building with c++17.
There is a hanging paren after the first #endif in optional.hpp, but in addition, the optional struct defines the bracket operator which is not defined on std::optional.
reply.cpp also didn't include the logger.hpp file containing the __CPP_REDIS_LOG macro.
Because of the std namespace override, the uses of the optional struct in the code needed to be replaced with optional_t.
Additionally, enableIf template needs to be added to the C++17 branch in optional.hpp.
Pull request incoming.

Activity

  1. GeoffHadlington commented on Jan 24, 2019

    @GeoffHadlington
    Author

    #9
    I believe this should resolve the problem satisfactorily for both c++17 and c++11

  2. EHadoux commented on Jan 24, 2019

    @EHadoux

    Hello, are you planning to merge into master today or later?

  3. GeoffHadlington commented on Jan 24, 2019

    @GeoffHadlington
    Author
  4. EHadoux commented on Jan 25, 2019

    @EHadoux

    Ahah that's fine don't worry, I'm compiling with your branch in the mean time.

  5. appkins commented on Mar 1, 2019

    @appkins

    I merged the changes into master. Thanks for the contribution!

  6. GeoffHadlington commented on Mar 1, 2019

    @GeoffHadlington
    Author
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions