You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
The bugfix to allow the use of the std::optional function from c++17 doesn't compile when building with c++17.
There is a hanging paren after the first #endif in optional.hpp, but in addition, the optional struct defines the bracket operator which is not defined on std::optional.
reply.cpp also didn't include the logger.hpp file containing the __CPP_REDIS_LOG macro.
Because of the std namespace override, the uses of the optional struct in the code needed to be replaced with optional_t.
Additionally, enableIf template needs to be added to the C++17 branch in optional.hpp.
Pull request incoming.
Activity
GeoffHadlington commentedon Jan 24, 2019
#9
I believe this should resolve the problem satisfactorily for both c++17 and c++11
EHadoux commentedon Jan 24, 2019
Hello, are you planning to merge into master today or later?
GeoffHadlington commentedon Jan 24, 2019
EHadoux commentedon Jan 25, 2019
Ahah that's fine don't worry, I'm compiling with your branch in the mean time.
appkins commentedon Mar 1, 2019
I merged the changes into master. Thanks for the contribution!
GeoffHadlington commentedon Mar 1, 2019