Skip to content

CONTRIBUTING.md testing instructions #12

Closed

Description

@dgpetrie

In CONTRIBUTING.md:
4. Build the entire library:
It referes to tests:
./bin/subscriber
./bin/client

Pardon, my ignorance if I missed something as I am a bit of a cmake newbie. I am not seeing any rules to build these targets.

Activity

  1. appkins commented on Mar 1, 2019

    @appkins

    In the CMake file, there is the following:

    if (BUILD_EXAMPLES)
    	add_subdirectory(examples)
    	# Reset variable to false to ensure tacopie does no build examples
    	set(BUILD_EXAMPLES false)
    endif (BUILD_EXAMPLES)
    

    Just pass -DBUILD_EXAMPLES=ON as a cmake param to build the examples.

    It's worth noting that we can make BUILD_EXAMPLES an option that can be tweaked using the cmake GUI. I'm happy to introduce these changes if the community prefers cache variables.

  2. dgpetrie commented on Mar 1, 2019

    @dgpetrie
    Author

    Thank you for the update on the build instructions.
    Sorry, if I am missing something, but that still does not produce:
    ./bin/subscriber
    ./bin/client

    It does produce:
    bin/cpp_redis_client
    bin/cpp_redis_future_client
    bin/cpp_redis_kill
    bin/cpp_redis_streams_client
    bin/cpp_redis_consumer
    bin/cpp_redis_high_availability_client
    bin/cpp_redis_logger
    bin/cpp_redis_subscriber

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions