You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
I'm interested in adding package hdf5 to hunter. It is a C++/Fortran/Java library to interact with hdf / h5 files. HDF5 is a standard hierarchical data file format commonly used to store raw sensor data as well as metadata.
Sounds good. The changes to hunterize are very minimal - are you interested in trying to get these merged upstream, or would you like a fork to be created in cpp-pm?
I was initially thinking of forking it in cpp-pm but happy to do a pull request upstream (before / in parallel?) to see if they are interested in adopting hunter :)
Thanks a lot, I'll apply the patch very soon and will let you know once it's done, I've built it on both linux & windows, do you guys have already set up a CI or anything similar to do a pre-release check?
The current testing model is pretty ugly, but essentially every package has a branch here https://github.com/cpp-pm/hunter-testing/branches, with modifications to just the Travis and appveyor build paths, so that just the specific package is built on that branch. To run the builds, you essentially just push a commit with the Travis/appveyor changes on top of your PR ones
Thanks!
For the patch, I previously patched the latest tag 1_10_5, would you rather patch develop (master seems pretty outdated, their branching is a bit of a mess...) or should I stick to the last release 1_10_5?
It’s up to you, but for stability reasons you probably want to stick to a formal release, unless you need the latest code for some reason. Also makes it easier for people to know which versions we have in hunter, versus a commit hash
Made the pull request in cpp-pm/hdf5.
I'm not familiar with travis files but if I understand correctly, all I need to do then is to amend pkg.hdf5 with up-to-date toolchains and once pushed it will run on the CI? Now the point that 's unclear to me is where is the branched to be build (the one of the pull request) specified?
The CI process is quite manual. The pkg.hd5 branch is really there just to track the state of testing for that package. To run the tests, you need to merge the pkg.hd5 and your hunter branch together, and push, and wait for the tests to run. It’s quite confusing - let me know if that makes sense
Activity
bkotzz commentedon Sep 23, 2019
Sounds good. The changes to hunterize are very minimal - are you interested in trying to get these merged upstream, or would you like a fork to be created in cpp-pm?
ThomasGuerneve commentedon Sep 23, 2019
I was initially thinking of forking it in cpp-pm but happy to do a pull request upstream (before / in parallel?) to see if they are interested in adopting hunter :)
bkotzz commentedon Sep 26, 2019
Don’t worry about it too much. We can make you a fork in cpp-pm
bkotzz commentedon Sep 26, 2019
https://github.com/cpp-pm/hdf5 Let us know if you are blocked on anything
ThomasGuerneve commentedon Sep 27, 2019
Thanks a lot, I'll apply the patch very soon and will let you know once it's done, I've built it on both linux & windows, do you guys have already set up a CI or anything similar to do a pre-release check?
bkotzz commentedon Sep 30, 2019
The current testing model is pretty ugly, but essentially every package has a branch here https://github.com/cpp-pm/hunter-testing/branches, with modifications to just the Travis and appveyor build paths, so that just the specific package is built on that branch. To run the builds, you essentially just push a commit with the Travis/appveyor changes on top of your PR ones
ThomasGuerneve commentedon Sep 30, 2019
Thanks!
For the patch, I previously patched the latest tag 1_10_5, would you rather patch develop (master seems pretty outdated, their branching is a bit of a mess...) or should I stick to the last release 1_10_5?
bkotzz commentedon Sep 30, 2019
It’s up to you, but for stability reasons you probably want to stick to a formal release, unless you need the latest code for some reason. Also makes it easier for people to know which versions we have in hunter, versus a commit hash
ThomasGuerneve commentedon Oct 1, 2019
Made the pull request in cpp-pm/hdf5.
I'm not familiar with travis files but if I understand correctly, all I need to do then is to amend pkg.hdf5 with up-to-date toolchains and once pushed it will run on the CI? Now the point that 's unclear to me is where is the branched to be build (the one of the pull request) specified?
bkotzz commentedon Oct 1, 2019
The CI process is quite manual. The pkg.hd5 branch is really there just to track the state of testing for that package. To run the tests, you need to merge the pkg.hd5 and your hunter branch together, and push, and wait for the tests to run. It’s quite confusing - let me know if that makes sense
ThomasGuerneve commentedon Oct 22, 2019
Updated hdf5 & released in: https://github.com/cpp-pm/hdf5/archive/1.10.5-hp5.tar.gz
hunter-testing (PR ) builds on:
NeroBurner commentedon Oct 10, 2025
closing old package request, please reopen and send PR if still interested