Skip to content

Add hdf5 package #12

Closed
Closed

Description

@ThomasGuerneve
  • I'm interested in adding package hdf5 to hunter. It is a C++/Fortran/Java library to interact with hdf / h5 files. HDF5 is a standard hierarchical data file format commonly used to store raw sensor data as well as metadata.
  • Here is the official site of the lib: https://www.hdfgroup.org/solutions/hdf5/
  • Used build system: [CMake] (built it with polly)

Only two dependencies were required ZLIB & szip, both on hunter (hence the hunterisation):


Activity

  1. bkotzz commented on Sep 23, 2019

    @bkotzz
    Member

    Sounds good. The changes to hunterize are very minimal - are you interested in trying to get these merged upstream, or would you like a fork to be created in cpp-pm?

  2. ThomasGuerneve commented on Sep 23, 2019

    @ThomasGuerneve
    Author

    I was initially thinking of forking it in cpp-pm but happy to do a pull request upstream (before / in parallel?) to see if they are interested in adopting hunter :)

  3. bkotzz commented on Sep 26, 2019

    @bkotzz
    Member

    Don’t worry about it too much. We can make you a fork in cpp-pm

  4. bkotzz commented on Sep 26, 2019

    @bkotzz
    Member

    https://github.com/cpp-pm/hdf5 Let us know if you are blocked on anything

  5. ThomasGuerneve commented on Sep 27, 2019

    @ThomasGuerneve
    Author

    Thanks a lot, I'll apply the patch very soon and will let you know once it's done, I've built it on both linux & windows, do you guys have already set up a CI or anything similar to do a pre-release check?

  6. bkotzz commented on Sep 30, 2019

    @bkotzz
    Member

    The current testing model is pretty ugly, but essentially every package has a branch here https://github.com/cpp-pm/hunter-testing/branches, with modifications to just the Travis and appveyor build paths, so that just the specific package is built on that branch. To run the builds, you essentially just push a commit with the Travis/appveyor changes on top of your PR ones

  7. ThomasGuerneve commented on Sep 30, 2019

    @ThomasGuerneve
    Author

    Thanks!
    For the patch, I previously patched the latest tag 1_10_5, would you rather patch develop (master seems pretty outdated, their branching is a bit of a mess...) or should I stick to the last release 1_10_5?

  8. bkotzz commented on Sep 30, 2019

    @bkotzz
    Member

    It’s up to you, but for stability reasons you probably want to stick to a formal release, unless you need the latest code for some reason. Also makes it easier for people to know which versions we have in hunter, versus a commit hash

  9. ThomasGuerneve commented on Oct 1, 2019

    @ThomasGuerneve
    Author

    Made the pull request in cpp-pm/hdf5.
    I'm not familiar with travis files but if I understand correctly, all I need to do then is to amend pkg.hdf5 with up-to-date toolchains and once pushed it will run on the CI? Now the point that 's unclear to me is where is the branched to be build (the one of the pull request) specified?

  10. bkotzz commented on Oct 1, 2019

    @bkotzz
    Member

    The CI process is quite manual. The pkg.hd5 branch is really there just to track the state of testing for that package. To run the tests, you need to merge the pkg.hd5 and your hunter branch together, and push, and wait for the tests to run. It’s quite confusing - let me know if that makes sense

  11. NeroBurner commented on Oct 10, 2025

    @NeroBurner

    closing old package request, please reopen and send PR if still interested

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    help wantedExtra attention is needed

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions