Skip to content

Support installing on Apple Silicon Macs - #10

Merged
stakach merged 1 commit into
cotag:masterfrom
crafterm:feature/remove-explicit-x86
Jan 5, 2021
Merged

stakach merged 1 commit into
cotag:masterfrom
crafterm:feature/remove-explicit-x86

Conversation

@crafterm

@crafterm crafterm commented Dec 7, 2020

Copy link
Copy Markdown
Contributor

Hi Team,

Hope all is going well.

The ext Rakefile currently assumes an x86 architecture for mac targets which prevents building an arm64 native bundle on an Apple Silicon Mac.

This PR removes that assumption - building for either platform now uses the right architecture:

ie. Intel Mac:

➜  http-parser git:(feature/remove-explicit-x86) ✗ file /Users/crafterm/.rbenv/versions/2.7.2/lib/ruby/gems/2.7.0/gems/http-parser-1.2.2/ext/x86_64-darwin/libhttp-parser-ext.bundle
/Users/crafterm/.rbenv/versions/2.7.2/lib/ruby/gems/2.7.0/gems/http-parser-1.2.2/ext/x86_64-darwin/libhttp-parser-ext.bundle: Mach-O 64-bit bundle x86_64

ie. Apple Silicon Mac

➜  http-parser git:(feature/remove-explicit-x86) ✗ file /Users/crafterm/.rbenv/versions/2.7.2/lib/ruby/gems/2.7.0/gems/http-parser-1.2.2/ext/arm-darwin/libhttp-parser-ext.bundle
/Users/crafterm/.rbenv/versions/2.7.2/lib/ruby/gems/2.7.0/gems/http-parser-1.2.2/ext/arm-darwin/libhttp-parser-ext.bundle: Mach-O 64-bit bundle arm64

Cheers,

M!

@MCarroll

MCarroll commented Jan 5, 2021

Copy link
Copy Markdown

/.rbenv/versions/3.0.0/lib/ruby/gems/3.0.0/gems/http-parser-1.2.2/ext/aarch64-darwin/libhttp-parser-ext.bundle: mach-o, but wrong architecture

@stakach
stakach merged commit 0655494 into cotag:master Jan 5, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants