Repository navigation
Bloodhound: Replace getIntersection method. - #121
Closed
kevinkneifel wants to merge 1 commit into
Closed
kevinkneifel wants to merge 1 commit into
kevinkneifel wants to merge 1 commit into
Conversation
…s only have one key, and that key value is less than the first key value in the ids array, which results in an empty intersection array.
Contributor
|
Refs #105 |
Darnokk
added a commit
to Darnokk/typeahead.js
that referenced
this pull request
Mar 5, 2018
Darnokk
added a commit
to Darnokk/typeahead.js
that referenced
this pull request
Mar 5, 2018
See corejavascript#121 and corejavascript#105 * generated files in /dist
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes functional error when matches array only has one key, and that key value is less than the first key value in the
idsarray, which results in an emptyintersectionarray. Uses the same logic as the_.intersection(array)method from underscore.js to safely find the intersection of the two arrays.