Repository navigation
Implement better authentication - #34
Merged
Merged
Conversation
DMA tries to authenticate by simply trying various authentication mechanisms. This is obviously not conforming to RFC and some mail providers detect this is spam and reject all emails. This patch parses the EHLO response and reads various keywords from it that can then later in the program be used to jump into certain code paths. Currently this is used to only authenticate with CRAM-MD5 and/or LOGIN if the server supports one or both of these. The implementation can be easily be extended though. Signed-off-by: Michael Tremer <michael.tremer@ipfire.org>
Owner
There was a problem hiding this comment.
I don't like this manual parsing. I know that dma is full of this kind of parsing, but we should try to keep it to a minimum.
Contributor
Author
There was a problem hiding this comment.
What do you mean? This is pretty much everywhere done this way. I didn't feel that using strstr() for searching for certain keywords would be a good idea.
Closed
Contributor
Author
|
Just want to remind that this issue is still open and I am still seeking for merging this patch if there is nothing else wrong with it that I should fix. |
Contributor
Author
|
Is there any chance to merge this patch, too? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
DMA tries to authenticate by simply trying various authentication
mechanisms. This is obviously not conforming to RFC and some mail
providers detect this is spam and reject all emails.
This patch parses the EHLO response and reads various keywords
from it that can then later in the program be used to jump into
certain code paths.
Currently this is used to only authenticate with CRAM-MD5 and/or
LOGIN if the server supports one or both of these. The
implementation can be easily be extended though.
Signed-off-by: Michael Tremer michael.tremer@ipfire.org