Repository navigation
presigned-url plugin: resolve default bucket from the request's database - #1936
Open
pyramation wants to merge 1 commit into
Open
pyramation wants to merge 1 commit into
pyramation wants to merge 1 commit into
Conversation
Contributor
|
I'll fix CI failures and address comments from users with write access. I'll skip comments containing "(aside)".
|
|
Review complete. No issues found — approved ✅. This PR updates the presigned URL plugin's managed upload path so the default bucket is resolved through the
Reviewed commit: 46c1780 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
resolveDefaultBucketno longer passes a database id;function_resolution.resolve_default_buckettakes the database from the request.The
databaseIdparameter is dropped fromresolveDefaultBucketand its two callers (plugin.ts,managed-upload.ts);managed-upload.test.tsexpectations updated to the new argument list.Link to Devin session: https://app.devin.ai/sessions/5f832b92b1d24c2ab1058f507aeacea5
Open in Devin Desktop: https://app.devin.ai/desktop/session/5f832b92b1d24c2ab1058f507aeacea5?variant=devin
Requested by: @pyramation