Skip to content

chore: bump fixture module pins - #1933

Merged
pyramation merged 1 commit into
mainfrom
feat/bump-fixture-pins-routing-private
Oct 26, 2026
Merged

pyramation merged 1 commit into
mainfrom
feat/bump-fixture-pins-routing-private

Conversation

@pyramation

Copy link
Copy Markdown
Contributor

Summary

Bumps the pgpm.json fixture pins (@constructive-db/{apps,catalog,routing,routing-platform}, @pgpm/function-resolution) to the latest published versions and aligns the test seeds with them: the platform plane's route_module names a routing_private schema, the direct resolver calls in the tests use routing_private.resolve_route, and the hostname_bindings inserts target the now-partial hostname index (ON CONFLICT (hostname) WHERE verification_status = 'verified').

Link to Devin session: https://app.devin.ai/sessions/ea7371d8dbc441c49cb46e16d1d97517
Open in Devin Desktop: https://app.devin.ai/desktop/session/ea7371d8dbc441c49cb46e16d1d97517?variant=devin
Requested by: @pyramation

@devin-ai-integration

Copy link
Copy Markdown
Contributor

I'll fix CI failures and address comments from users with write access. I'll skip comments containing "(aside)".

  • Disable automatic comment, CI, and merge conflict monitoring

@tenki-reviewer

tenki-reviewer Bot commented Oct 25, 2026 •

Copy link
Copy Markdown

Review complete. No issues found — approved ✅.


This PR aligns the test fixtures and integration tests with the routing module's new private-schema resolver model: the resolver now lives in routing_private rather than the public plane, and both seed fixtures are updated in lockstep to reflect that.

Files Change
__fixtures__/seed/scoped/test-data.sql, graphql/server-test/__fixtures__/seed/tenant-routing-planes/test-data.sql Seed a new routing_private schema row (is_public=false), wire route_module.private_schema_id to it, and use partial-index ON CONFLICT arbiter clauses on hostname inserts.
graphql/server-test/__tests__/scoped-routing.integration.test.ts, fn-routes.integration.test.ts, express-context.integration.test.ts, server.integration.test.ts Update integration tests to resolve routes via routing_private.resolve_route and cover the private-plane routing path.
graphql/playwright-test/__tests__/scoped-server.playwright.test.ts, src/server.ts Update the Playwright server harness and scoped-server test to match the new routing setup.
pgpm.json Bump @constructive-db/routing (8.6.0 → 8.9.0) and function-resolution (0.47.7 → 0.47.8) module versions.

Reviewed commit: c330106

@pyramation
pyramation merged commit 99303f9 into main Oct 26, 2026
20 checks passed
@pyramation
pyramation deleted the feat/bump-fixture-pins-routing-private branch October 26, 2026 20:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant