Repository navigation
fix(graphql-server): declare cookie-parser as a runtime dependency - #1930
Merged
Merged
Conversation
Contributor
|
I'll fix CI failures and address comments from users with write access. I'll skip comments containing "(aside)".
|
|
Review complete. No issues found — approved ✅. This PR makes a single dependency-manifest change in Reviewed commit: 4d195f0 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
graphql/server/src/server.tsdoesimport cookieParser from 'cookie-parser'at runtime, butcookie-parserwas listed underdevDependencies. The published@constructive-io/graphql-server@5.32.7therefore doesn't install it, sonpx @constructive-io/cli@8.22.7 servercrashes on start withCannot find module 'cookie-parser'outside this monorepo.You can see it in the registry today:
npm view @constructive-io/graphql-server@5.32.7 dependencieshas nocookie-parser.The fix moves
cookie-parserfromdevDependenciestodependencies, and moves the same entry in the lockfile importer. The resolved version stays1.4.7, so no package resolution changes.Link to Devin session: https://app.devin.ai/sessions/606ffc9866e54e4aa7140e33324662df
Open in Devin Desktop: https://app.devin.ai/desktop/session/606ffc9866e54e4aa7140e33324662df?variant=devin
Requested by: @pyramation