Skip to content

feat(conventional_commits): use and proper support for conventional c… - #235

Merged
Lee-W merged 1 commit into
masterfrom
feat/conventional-commits-1.0
Jul 26, 2020
Merged

Lee-W merged 1 commit into
masterfrom
feat/conventional-commits-1.0

Conversation

@woile

@woile woile commented Jul 26, 2020

Copy link
Copy Markdown
Member

…ommits v1.0.0

Types of changes

  • [] Bug fix
  • New feature
  • Refactoring
  • Breaking change (any change that would cause existing functionality to not work as expected)
  • Documentation update
  • Other (please describe)

Description

Add proper support for conventional commits 1.0
This does not introduce a breaking change for commitizen.

Checklist

  • Add test cases to all the changes you introduce
  • Run ./script/format and ./script/test locally to ensure this change passes linter check and test
  • Test the changes on the local machine manually

Related Issue

Closes #199

@codecov

codecov Bot commented Jul 26, 2020

Copy link
Copy Markdown

Codecov Report

Merging #235 into master will increase coverage by 0.00%.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #235   +/-   ##
=======================================
  Coverage   95.70%   95.71%           
=======================================
  Files          34       34           
  Lines         955      957    +2     
=======================================
+ Hits          914      916    +2     
  Misses         41       41           
Flag Coverage Δ
#unittests 95.71% <100.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
commitizen/__version__.py 100.00% <100.00%> (ø)
...en/cz/conventional_commits/conventional_commits.py 98.41% <100.00%> (ø)
commitizen/git.py 95.55% <100.00%> (+0.10%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 20449e9...a2188e5. Read the comment docs.

@woile
woile requested a review from Lee-W July 26, 2020 13:41
@Lee-W
Lee-W merged commit 9b911e3 into master Jul 26, 2020
@Lee-W
Lee-W deleted the feat/conventional-commits-1.0 branch July 26, 2020 13:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

commitzen is not fully compatible with the latest conventional commit

2 participants