Skip to content

2.0.0 breaking changes - #230

Merged
Lee-W merged 5 commits into
nextfrom
2.0.0-break-changes
Jul 26, 2020
Merged

Lee-W merged 5 commits into
nextfrom
2.0.0-break-changes

Conversation

@Lee-W

@Lee-W Lee-W commented Jul 25, 2020

Copy link
Copy Markdown
Member

Types of changes

  • Bug fix
  • Refactoring
  • Breaking change (any change that would cause existing functionality to not work as expected)
  • Documentation update

Description

  • drop "files" configure support. Please use "version_files" instead
  • remove ini configuration support
  • remove "--version" argument for command line
  • make command required for commitizen command line

Checklist

  • Add test cases to all the changes you introduce
  • Run ./script/format and ./script/test locally to ensure this change passes linter check and test
  • Test the changes on the local machine manually
  • Update the documentation for the changes

Steps to Test This Pull Request

  • drop "files" configure support. Please use "version_files" instead
    1. use "version_files" in the configuration file
    2. use "files" in configuration file
  • remove ini configuration support
    • use .cz, setup.cfg or .cz.cfg as configuration file
  • remove "--version" argument for command line
    • run cz --version
  • make command required for commitizen command line
    • run cz --debug

Expected behavior

  • drop "files" configure support. Please use "version_files" instead
    1. versions in "version_files" should be updated
    2. versions in "files" should be updated.
  • remove ini configuration support
    • the configuration inside these files should not affect any behavior
  • remove "--version" argument for command line
    • Command is required should show up
  • make command required for commitizen command line
    • Command is required should show up

Related Issue

#47, #55, #82

Additional context

@Lee-W
Lee-W marked this pull request as draft July 25, 2020 14:58
Lee-W added 4 commits July 26, 2020 16:40
BREAKING CHANGE: "cz --debug" will no longer work
 #47
BREAKING CHANGE: Use "cz verion" instead
BREAKING CHANGE: setup.cfg, .cz and .cz.cfg are no longer supported
@Lee-W
Lee-W force-pushed the 2.0.0-break-changes branch from 5b73ad4 to f7809df Compare July 26, 2020 08:42
@codecov

codecov Bot commented Jul 26, 2020 •

Copy link
Copy Markdown

Codecov Report

❗ No coverage uploaded for pull request base (next@ab91e62). Click here to learn what that means.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##             next     #230   +/-   ##
=======================================
  Coverage        ?   96.58%           
=======================================
  Files           ?       33           
  Lines           ?      878           
  Branches        ?        0           
=======================================
  Hits            ?      848           
  Misses          ?       30           
  Partials        ?        0           
Flag Coverage Δ
#unittests 96.58% <0.00%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.


Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ab91e62...4dd29a5. Read the comment docs.

@Lee-W
Lee-W marked this pull request as ready for review July 26, 2020 08:58
@woile

woile commented Jul 26, 2020

Copy link
Copy Markdown
Member

titanic work 🎉

@Lee-W
Lee-W merged commit 57be0f3 into next Jul 26, 2020
@Lee-W
Lee-W deleted the 2.0.0-break-changes branch July 26, 2020 15:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants