Repository navigation
Fix pre commit hook - #135
Merged
Merged
Conversation
4 tasks done
Contributor
|
@Lee-W, I believe it was correct before. Hooks can confine themselves to particular stages when they know they would only be useful in those stages. Maybe one could argue that there is value in adding |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In the previous pre-commit PR, I add the wrong
stagesargument into the.pre-commit-hooks.yaml. It should be defined on the user side. I'll also update the document.BTW, I notice it didn't bump the version and release on the previous PR.