Repository navigation
Tests Fail Depending on tomlkit Version #628
Description
Activity
- changed the title
[-]PR #626 Breaks Tests[/-][+]Update `pyproject.toml` dependency version for `tomlkit`[/+]on Dec 3, 2022 - changed the title
[-]Update `pyproject.toml` dependency version for `tomlkit`[/-][+]Update version for `tomlkit` in `pyproject.toml`[/+]on Dec 3, 2022 - changed the title
[-]Update version for `tomlkit` in `pyproject.toml`[/-][+]Tests Fail Depending on `tomlkit` Version[/+]on Dec 3, 2022 I prefer the second one.
In case this issue remains open until support for Python 3.10 is dropped, tomlib was added to the standard library in Python 3.11, so the dependency on tomlkit can eventually be dropped.
Any update on this? Is it still happening on
v3?
ThanksTriage from #1964: This is stale —
pyproject.tomlcurrently pinstomlkit (>=0.8.0,<1.0.0), and CI passes on master across Python 3.10-3.14 / Linux / macOS / Windows. The original 0.11.5 vs 0.11.6 discrepancy should no longer be relevant. Suggesting we close unless someone is actively running into it.Verification update (re #1964)
Verified against current master (4.15.1):
pyproject.tomlpin:tomlkit (>=0.8.0,<1.0.0)- Resolved tomlkit in commitizen's lockfile:
0.14.0 - Test files mentioned in this issue (
test_bump_command.py,test_init_command.py,test_conf.py) all pass on current master with resolved tomlkit.
The original 0.11.5 vs 0.11.6 distinction (December 2022) is no longer exercised by the test suite. CI matrix passes across Python 3.10–3.14 / Linux / macOS / Windows.
Verdict: STALE. Closing-eligible.
(Tangentially related: #1500 reopens the "broad tomlkit pin" concern from a different angle — old tomlkit can still mishandle PEP-735
[dependency-groups]includes. Bumping the lower bound to>=0.13.0would address both #628 and #1500 cleanly.)Closing as stale: tomlkit 0.11.5 vs 0.11.6 distinction is no longer exercised by the test suite. CI passes across the matrix with current resolved tomlkit (0.14.0). See verification comment above.
Description
PR #626 changed
to accomodate changes to
tomlkitfrom0.11.5to0.11.6. However, thepyproject.tomlstill has the version set asHence, tests fail for
tomlkit<=0.11.5.Steps to reproduce
Run
pytestoncommitizenrepo withtomlkit<=0.11.5.Current behavior
The following 6 tests fail:
pytest_report.zip
when
tomlkitis<= 0.11.5, but pass whentomlkit >= 0.11.6.Desired behavior
Either of the following, depending on what should be supported:
Update
pyproject.tomlto specifyor
tomlkit<=0.11.5separate from test cases fortomlkit > 0.11.5.Screenshots
No response
Environment
2.37.13.8.10Windows 10