/bin/sh not on Windows #602

Activity

1. adam-grant-hendry

   added

   type: bug

   on Oct 14, 2022
2. adam-grant-hendry commented on Oct 14, 2022

   

   adam-grant-hendry

   on Oct 14, 2022

   Last edited by adam-grant-hendry

   ContributorAuthor

   More actions

   Substituting the portable shebang works. However, pytest reports many failing tests and errors (completely unrelated to the changes). The following report was generated with pytest-html:

   pytest_report.zip
3. Lee-W commented on Oct 17, 2022

   

   Lee-W

   on Oct 17, 2022

   Member

   More actions

   Hi @adam-grant-hendry , thanks for your report. The html seems to miss some style and barely readable now. Could you guide me through on how to view it correctly? Or could you please share a few example on what you're testing and what's not working even with shebang?
4. jenstroeger commented on Oct 17, 2022

   

   jenstroeger

   on Oct 17, 2022

   Contributor

   More actions

   @adam-grant-hendry are you on vanilla Windows, or do you use WSL or some other *NIX port on Windows?

   I ask because both format and test scripts are sh (e.g. bash and co) scripts that assume an appropriate environment.
5. adam-grant-hendry commented on Oct 17, 2022

   

   adam-grant-hendry

   on Oct 17, 2022

   Last edited by adam-grant-hendry

   ContributorAuthor

   More actions

   The html seems to miss some style and barely readable now. Could you guide me through on how to view it correctly?

   I forgot to zip the CSS assets with it, my mistake. I updated the link, so please try downloading and unzipping again. You should see a folder assets with a file style.css in addition to pytest_report.html that will help it render properly.

   I ask because both format and test scripts are sh (e.g. bash and co) scripts that assume an appropriate environment.

   I use vanilla Windows. The fact the test scripts require that environment is not specified in the Contributing Guide. Rather than switching over to WSL or Cygwin/MSYS, I changed the shebang to a portable variant. My users use Windows, so I develop on Windows (it's easier for me to find problems and help them that way).

   Regardless, the greater problem is your Windows CI doesn't run. Even if I switched to WSL or Cygwin/MSYS, I have no confidence that commitizen will work for my PowerShell users.

   Is commitizen intended only to be used by bash/sh users? That's going to cut off a lot of end users from using it, especially if they're in a restricted environment (e.g. corporate setting) that does not permit them to use these shells.
6. Lee-W commented on Oct 20, 2022

   

   Lee-W

   on Oct 20, 2022

   Last edited by Lee-W

   Member

   More actions

   I just saw your test output. Could you please install https://gnupg.org/download/ and see how it works? It seems the doc is outdated. Before we add it to the doc, let's verify whether installing gpg fix it

   ---

   Is commitizen intended only to be used by bash/sh users? T

   Ideally, no. We hope this project can be used by all users.
7. adam-grant-hendry commented on Oct 20, 2022

   

   adam-grant-hendry

   on Oct 20, 2022

   ContributorAuthor

   More actions

   I just saw your test output. Could you please install https://gnupg.org/download/ and see how it works? It seems the doc is outdated. Before we add it to the doc, let's verify whether installing gpg fix it

   I installed that and also tested out gpg.exe that ships with Git for Windows (it resides in C:\Program Files\Git\usr\bin. Both work well.

   All tests are now passing in PR #605, so I was able to fix all the errors previously experienced on Windows. Please kindly re-review it at your earliest convenience.

   Thank you!
8. adam-grant-hendry

   closed this as completedon Dec 3, 2022