Skip to content

(Optional?) support for annotated tags #329

Closed

Description

@SpokeyWheeler

Description

Currently, lightweight tags are generated by cz bump. This means you have to remember to push the tag separately from the commit, and also means you can't use --follow-tags.

Possible Solution

I did this in my clone, but I genuinely don't know if it's anything more than a hack:

I changed this line from
c = cmd.run(f"git tag {tag}")
to
c = cmd.run(f"git tag -a -m '{tag}' {tag}")

DISCLAIMER: I wouldn't know Python if it ran me over in a bus. But it seemed to work!

Additional context

N/A

Related Issue

I didn't find anything related.

Activity

  1. woile commented on Jan 11, 2021

    @woile
    Member

    There's an open (abandoned) PR for annotated tags: #272
    Feel free to add corrections and re-submit it. I'll try to pick it up but I'm quite busy atm

  2. SpokeyWheeler commented on Jan 12, 2021

    @SpokeyWheeler
    Author

    Honestly, I've never written any Python in anger before. I don't feel comfortable with starting with this! :-)

  3. woile commented on Jan 12, 2021

    @woile
    Member

    No worries, thanks for sharing. I'll try to push this change in the coming weeks 💪🏻

  4. cliles commented on Jan 15, 2021

    @cliles

    @woile - To help speed this up (to maybe days instead of weeks), I went ahead and looked at #272 and "adopted" it for #332.

  5. SpokeyWheeler commented on Jan 16, 2021

    @SpokeyWheeler
    Author

    Thanks guys!

  6. cliles commented on Jan 24, 2021

    @cliles

    @woile and @SpokeyWheeler - #332 is merged, this issue can be closed.

  7. SpokeyWheeler commented on Jan 25, 2021

    @SpokeyWheeler
    Author

    Awesome! Thank you so much! 🎉🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions