You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Yes, they should. There's a bug, the new CI is using secrets.GITHUB_TOKEN, but we should go back to secrets.PERSONAL_ACCESS_TOKEN, because the first one doesn't trigger new builds :/
mmm not really. The vision we have is a bit more decoupled.
a new commit to master triggers a bump version, which in turn will push a tag.
a new tag with the format v* triggers a publish. This means that if I want to make a release pushing a local tag we can (for example a release candidate).
See it like "which git event triggers which action".
The update I mention is when we started using our own github action, you can see the change here
I manually pushed the tags in order to trigger the action.
Since we introduced the github action, it doesn't trigger other github actions. We need to find out why.
I'm still not sure, because I've updated the secret to use the PERSONAL_ACCESS_TOKEN.
AFAIK if you use GITHUB_TOKEN it doesn't trigger other jobs, kind of like using [skip ci], so you have to use your own token to trigger the jobs. But again, I updated the token, and it didn't make a release. Maybe some leftovers, and the next release will work.
Activity
woile commentedon Sep 3, 2020
Yes, they should. There's a bug, the new CI is using
secrets.GITHUB_TOKEN, but we should go back tosecrets.PERSONAL_ACCESS_TOKEN, because the first one doesn't trigger new builds :/alecgerona commentedon Sep 3, 2020
By new CI you mean github actions? Shouldn't we just merge bump version and publish into one workflow? So bump then publish.
woile commentedon Sep 3, 2020
mmm not really. The vision we have is a bit more decoupled.
v*triggers a publish. This means that if I want to make a release pushing a local tag we can (for example a release candidate).See it like "which git event triggers which action".
The update I mention is when we started using our own github action, you can see the change here
It's fixed now, a new release will happen soon
alecgerona commentedon Sep 3, 2020
We can have release candidates or alphas or betas as branches, too. Just for context my flow draws from how semantic-release does it.
alecgerona commentedon Sep 6, 2020
Hmm I think there's no release yet.
woile commentedon Sep 7, 2020
I've released the latest versions, but indeed it's not automatically releasing, I'll make an investigation
alecgerona commentedon Sep 7, 2020
Thanks! Let's close this once it's resolved. If you need help lemme know.
Lee-W commentedon Sep 8, 2020
Is it the action that releases 2.3.1?
https://github.com/commitizen-tools/commitizen/actions/runs/242737189
alecgerona commentedon Sep 8, 2020
Seems like it.
Lee-W commentedon Sep 9, 2020
Is there anything we need to do for this issue?
woile commentedon Sep 9, 2020
I manually pushed the tags in order to trigger the action.
Since we introduced the github action, it doesn't trigger other github actions. We need to find out why.
I'm still not sure, because I've updated the secret to use the
PERSONAL_ACCESS_TOKEN.AFAIK if you use
GITHUB_TOKENit doesn't trigger other jobs, kind of like using[skip ci], so you have to use your own token to trigger the jobs. But again, I updated the token, and it didn't make a release. Maybe some leftovers, and the next release will work.Lee-W commentedon Sep 9, 2020
Got it. Thanks for the explanation 😄
woile commentedon Oct 27, 2020
Releases are working fine again