Skip to content

Enable ruff rule PGH003 #1501

Closed
Closed
Enable ruff rule PGH003#1501
Labels
issue-status: wait-for-implementationmaintainers agree on the bug / feature

Description

@bearomorphism
bearomorphism
opened on Jun 4, 2025

If you don't mind the extra effort and want better safety, I recommend enabling the ruff rule PGH003.

It enforces that all type: ignore comments must specify a clear scope, rather than ignoring all type checks.
For more details on the drawbacks, please refer to the explanation in the ruff documentation above.

Originally posted by @gbaian10 in #1466 (comment)

Activity

  1. github-actions
    added
    issue-status: needs-triage
    on Jun 4, 2025
  2. bearomorphism
    changed the title [-]If you don't mind the extra effort and want better safety, I recommend enabling the `ruff` rule [PGH003](https://docs.astral.sh/ruff/rules/blanket-type-ignore/).[/-] [+]Enable `ruff` rule PGH003[/+] on Jun 4, 2025
  3. Lee-W
    added
    issue-status: wait-for-implementationmaintainers agree on the bug / feature
    and removed
    issue-status: needs-triage
    on Jun 5, 2025

  4. bearomorphism commented on Jun 8, 2025

    @bearomorphism
    bearomorphism
    on Jun 8, 2025
    CollaboratorAuthor

    I can quickly implement this.

  5. Lee-W commented on Jun 9, 2025

    @Lee-W
    Lee-W
    on Jun 9, 2025
    Member

    Close as 4.8.3 released

  6. Lee-W
    closed this as completedon Jun 9, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    issue-status: wait-for-implementationmaintainers agree on the bug / feature

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions