Skip to content

_valid_command_argument #1498

Closed
Closed
_valid_command_argument#1498
Labels
issue-status: needs-triagetype: featureA new enhacement proposal

Description

@bearomorphism
bearomorphism
opened on Jun 3, 2025

Description

I just think it's not a good design to validate and reassign things in a function. The function name itself is confusing.

commitizen/commitizen/commands/check.py

Lines 51 to 62 in 47beadc

def _valid_command_argument(self):
num_exclusive_args_provided = sum(
arg is not None
for arg in (self.commit_msg_file, self.commit_msg, self.rev_range)
)
if num_exclusive_args_provided == 0 and not sys.stdin.isatty():
self.commit_msg = sys.stdin.read()
elif num_exclusive_args_provided != 1:
raise InvalidCommandArgumentError(
"Only one of --rev-range, --message, and --commit-msg-file is permitted by check command! "
"See 'cz check -h' for more information"
)

Possible Solution

No response

Additional context

No response

Additional context

No response

Activity

  1. bearomorphism
    added
    type: featureA new enhacement proposal
    on Jun 3, 2025
  2. github-actions
    added
    issue-status: needs-triage
    on Jun 3, 2025

  3. bearomorphism commented on Sep 19, 2025

    @bearomorphism
    bearomorphism
    on Sep 19, 2025
    CollaboratorAuthor

    Closing this since #1519 is merged into master branch.

  4. bearomorphism
    closed this as completedon Sep 19, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    issue-status: needs-triagetype: featureA new enhacement proposal

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions