Skip to content

Check every commit message in PR CI #1493

Closed

Description

@bearomorphism

Description

For example, the following PR check should fail because the first commit message does not follow the Conventional Commit pattern.

Image

Related PR: #1400 (still a draft now)

@Lee-W: A possible temporary approach is adding cz check --rev-range origin/master in pyproject.toml

Activity

  1. bearomorphism commented on Jun 2, 2025

    @bearomorphism
    CollaboratorAuthor

    BTW I think check-commit should be the first step of all.sequence?

  2. Lee-W commented on Jun 2, 2025

    @Lee-W
    Member

    BTW I think check-commit should be the first step of all.sequence?

    Sounds good. Should start with things that finish earlier

  3. bearomorphism commented on Jun 2, 2025

    @bearomorphism
    CollaboratorAuthor

    BTW I think check-commit should be the first step of all.sequence?

    Sounds good. Should start with things that finish earlier

    Yeah I reordered the steps in #1494

  4. Lee-W commented on Jun 9, 2025

    @Lee-W
    Member

    I think we have a temporary solution already. The ultimate solution will need to wait for the rev-range improvement. closing this one

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions