Skip to content

Add option pass on NoCommitsFoundError  #21

Closed

Description

@datanrd

If you use a change type like ci:, build:, docs:, style: or chore:, it won't bump the version unless you add it to the bump_pattern and bump_map. You may not want to bump the version for these change types. I propose adding
an option to allow pass on NoCommitsFoundError. In the exit codes documentation, it throws an error code of 3 when no commits are found. An option to allow pass on no commits found will allow for simpler workflows. For example, if I update the docs or other change types that don't necessitate a release, with an option like allow_no_commits I won't have to put parsing around the commit message to not run. With the this option runs the risks of swallowing unintentional errors.

Activity

  1. changed the title [-]Add option to allow pass on NoCommitsFoundError [/-] [+]Add option pass on NoCommitsFoundError [/+] on Mar 2, 2022
  2. woile commented on Mar 3, 2022

    @woile
    Member

    We have planned a feature on commitizen directly that we'll try to implement soon:
    commitizen-tools/commitizen#485

  3. Kurt-von-Laven commented on Apr 7, 2022

    @Kurt-von-Laven
    Contributor

    This would be great to have. I would guess that this issue makes the Commitizen action incompatible with Dependabot and similar automated upgrade tools that may routinely open pull requests that only upgrade development dependencies and don't imply a version bump. When I merge a pull request that doesn't imply a version bump, I have to remember to manually delete the subsequent failing Commitizen workflow run, or the build will misleadingly appear to be red after merging a passing pull request.

  4. woile commented on Apr 7, 2022

    @woile
    Member

    The PR is almost ready

  5. Kurt-von-Laven commented on Apr 25, 2022

    @Kurt-von-Laven
    Contributor

    I saw the aforementioned excellent feature released in Commitizen 2.24.0. Is there a way to pass --no-raise through to commitizen from this action, or does a new input need to be added?

  6. woile commented on Apr 29, 2022

    @woile
    Member

    Please review PR 🙏🏻

  7. woile commented on Oct 11, 2022

    @woile
    Member
  8. Kurt-von-Laven commented on Oct 11, 2022

    @Kurt-von-Laven
    Contributor

    @woile, did you mean that reply for a different thread? --no-raise has been available via the action since May.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions