Repository navigation
Conversation
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Virtual-camera keypoints are appended to the output panorama in contiguous blocks. The reverse mapping currently creates a dictionary entry and a tuple for every keypoint, including ones without a 3D observation. Record the output image, starting offset and count once per virtual image and recover each track index from that block. Keep an explicit check against writing beyond the source image's keypoint block.
A Python 3.12 harness ran the production conversion method with NumPy projections and stand-ins for native reconstruction containers. For 40 virtual images (including ten empty images), 36,000 keypoints and 600 observations, every output coordinate and track index matched the original. Python tracemalloc peak dropped from 6,359,504 to 1,267,296 bytes. Added a synthetic native-PyCOLMAP regression.
Additional native validation used the official Linux x86-64 CPU PyCOLMAP wheel from the exact upstream commit 3c1a1b9 (Actions run 42531153531). 14 tests passed in the affected Python module. Ruff 0.16.10 formatting and lint checks passed on the changed Python files.