Repository navigation
Conversation
Patch Node 22.15.0 -> 22.23.4 on the 26.3 line: all hardcoded node-version pins in the fe-* workflows, .nvmrc, .tool-versions, package.json engines (node 22.23.4 / npm 10.9.9) and @types/node ^22.20.5. package-lock.json regenerated with npm 10.9.9. fe-e2e.yml no longer runs in the cypress/browsers:22.15.0 container (no 22.23.x Cypress image exists); it uses actions/setup-node with 22.23.4 as on release/26.1. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
senthanal
requested review from
alekhya-cplace and
slaven3kopic
as code owners
October 27, 2026 22:02
Contributor
|
Review note (CVE-2026-111497 roll-out, head 40b0620): All version bumps match the expected pattern. As in #185, fe-e2e.yml leaves the cypress/browsers container and runs with setup-node 22.23.4 on ubuntu-latest (no Node 22 Cypress image newer than 22.21.0 exists). This changes the runtime of every partner e2e job on 26.3 and nothing in this repo's CI exercises it. Could you link one green e2e run that used this branch (for example a cplace-fe release/26.3 run calling |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolves PFM-TASK-8711 (part of PFM-ISSUE-35254)
changelog: Platform Experience: [PFM-TASK-8711] Functionality: Node 22.23.4 security patch rollout (CVE-2026-111497) [PR github-actions#186]Patches Node
22.15.0→22.23.4onrelease/26.3to address CVE-2026-111497 (Node2Shell, Brotli decoder). This is the 26.3 counterpart of #184 (26.1) and #185 (26.2); the commit is the #185 change applied onrelease/26.3without conflicts. Patch bump within Node 22, no Angular impact.Files changed
.github/workflows/fe-*.yml(11 files)node-version: 22.15.0→22.23.4.github/workflows/fe-e2e.ymlcypress/browsers:22.15.0(--user 1001); addedactions/setup-node(v6.4.0, same SHA pin as the other workflows) with22.23.4after checkout, as onrelease/26.1.nvmrcv22.15.0→v22.23.4.tool-versionsnodejs 22.23.4, addednpm 10.9.9package.jsonengines(node22.23.4/ npm10.9.9, the npm bundled with 22.23.4);@types/node^22.15.0→^22.20.5package-lock.jsonengines+@types/nodeonly (same lock diff as #184 / #185)fe-sonar.ymlalready usesnode-version-file: .nvmrc; no change.Points for review
cypress/browsersimage for Node 22.23.x. Without it, the e2e job runs on the plainubuntu-latestrunner with its preinstalled browsers, as onrelease/26.1, and may run slower. TheNODE_OPTIONS/CYPRESS_NO_COMMAND_LOGenv vars are kept.run-many@release/26.3ref,fe-e2e.ymlmatches the PFM-TASK-8708 - Roll out Node 22.23.4 to github-actions repo (26.2) #185 version.Testing
Follow-up
v2.3.9) → frontend → backend. No Friday merges.Developer Checklist:
to Guidelines
🤖 Generated with Claude Code