Repository navigation
Enable proposed API by default - #12
Merged
Merged
Conversation
Turns out we used to already do this and if you passed the flag you would actually *disable* the global enable setting. This is becaues we were defaulting to an empty array which means to enable it globally. Fixes coder/code-server#4397 Fixes coder/code-server#4480
jsjoeio
approved these changes
Nov 10, 2021
jsjoeio
left a comment
jsjoeio
left a comment
There was a problem hiding this comment.
I am always impressed at how small (LOC) your changes are, yet they enable big features or fix big bugs 😂
code-asher
added a commit
that referenced
this pull request
Nov 10, 2021
Turns out we used to already do this and if you passed the flag you would actually *disable* the global enable setting. This is because we were defaulting to an empty array which means to enable it globally. Fixes coder/code-server#4397 Fixes coder/code-server#4480
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Turns out we used to already do this and if you passed the flag you
would actually disable the global enable setting. This is because we
were defaulting to an empty array which means to enable it globally.
Fixes coder/code-server#4397
Fixes coder/code-server#4480