This repository was archived by the owner on Jan 17, 2021. It is now read-only.
Repository navigation
Conversation
gyzerok
commented
May 10, 2020
| fl.BoolVar(&c.noReuseConnection, "no-reuse-connection", false, "do not reuse SSH connection via control socket") | ||
| fl.BoolVar(&c.disableTelemetry, "disable-telemetry", false, "pass --disable-telemetry flag to code-server") | ||
| fl.StringVar(&c.bindAddr, "bind", "", "local bind address for SSH tunnel, in [HOST][:PORT] syntax (default: 127.0.0.1)") | ||
| fl.StringVar(&c.remotePort, "remote-port", "", "specify remote port on which code-server will be started") |
Author
There was a problem hiding this comment.
Also could be --code-server-port. Which one do you think is better?
gyzerok
commented
May 10, 2020
gyzerok
commented
May 10, 2020
| sshCmdStr := | ||
| fmt.Sprintf("ssh -tt -q -L %v:localhost:%v %v %v '%v %v --host 127.0.0.1 --auth none --port=%v'", | ||
| o.bindAddr, o.remotePort, o.sshFlags, host, codeServerPath, dir, o.remotePort, | ||
| fmt.Sprintf("ssh -tt -q -L %v:127.0.0.1:%v %v %v '%v'", |
Author
There was a problem hiding this comment.
Changed to 127.0.0.1 so it matches what is written in --host just for consistency.
…, so switch to the previous cli args
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #177
Hello!
Full disclaimer: I have a very limited Go experience. Hopefully the way I've implemented this looks reasonable. However I am willing to take any suggestions on how to improve.