Skip to content
This repository was archived by the owner on Jan 17, 2021. It is now read-only.
This repository was archived by the owner on Jan 17, 2021. It is now read-only.

Ctrl-J in extensions view opens up Chrome downloads page instead of VSCode terminal #151

Open

Description

@samuela

Title really says it all. A lot of the time when I hit Ctrl-J, it ends up opening the Chrome "Downloads" page instead of toggling the VSCode terminal on/off.

Activity

  1. Merith-TK commented on Nov 24, 2019

    @Merith-TK
    Contributor

    Yeah due to the nature of the software, thare are some keybinds that cant be controlled, also i feel as if this is a issue for normal Code-Server as this has to deal with code-server and NOT sshcode

    EDIT: the default keymap for opening the terminal is CTRL+SHIFT+~

  2. samuela commented on Nov 25, 2019

    @samuela
    Author

    Oh, that's right. Ctrl-J is toggles the bottom bar thingy, but not the terminal per se.

  3. Merith-TK commented on Nov 26, 2019

    @Merith-TK
    Contributor

    Also i cannot reproduce this

  4. samuela commented on Nov 26, 2019

    @samuela
    Author

    I'm running Chromium 74.0.3729.157 (Official Build) Built on Raspbian , running on Raspbian 10 (32-bit). sshcode installed via go get -u go.coder.com/sshcode.

    Maybe it's a Chrome vs Chromium issue? I should also point out that it doesn't occur every time... There are certain scenarios in which Ctrl-J works just as expected and others where it opens up the Downloads page.

  5. Merith-TK commented on Nov 26, 2019

    @Merith-TK
    Contributor

    Hmm, not really,
    I use brave with no issue, but it might be the fact that you are using a Pi?

  6. samuela commented on Nov 26, 2019

    @samuela
    Author

    Possibly, I'd imagine it has to do with how the browser shim propagates keyboard events but I can't be sure of that.

  7. Merith-TK commented on Nov 26, 2019

    @Merith-TK
    Contributor
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions