Skip to content
This repository was archived by the owner on May 23, 2021. It is now read-only.
This repository was archived by the owner on May 23, 2021. It is now read-only.

Extract native modules uniquely #4

Closed
Closed
Extract native modules uniquely#4

Description

@kylecarbs
kylecarbs
opened on Apr 4, 2019

https://github.com/codercom/nbin/blob/74da4b366f5c37ea47d83d3e73384e5a3307e00c/node.patch#L108

We don't check if the .node file extracted is different than the .node file in the binary.

We could do this by hashing the embedded .node file, or by checking size for now.

Activity

  1. code-asher commented on Apr 9, 2019

    @code-asher
    code-asher
    on Apr 9, 2019
    Member

    We've decided to keep extracting them each time since it'll only happen once and might be less expensive than hashing anyway.

  2. code-asher
    closed this as completedon Apr 9, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions