Skip to content
Navigation Menu
Sign in
Appearance settings
Platform
AI CODE CREATION
GitHub Copilot
Write better code with AI
GitHub Copilot app
Direct agents from issue to merge
MCP Registry
Integrate external tools
DEVELOPER WORKFLOWS
Actions
Automate any workflow
Codespaces
Instant dev environments
Issues
Plan and track work
Code Review
Manage code changes
Code Quality
Enforce quality at merge
APPLICATION SECURITY
GitHub Advanced Security
Find and fix vulnerabilities
Code security
Secure your code as you build
Secret protection
Stop leaks before they start
EXPLORE
Why GitHub
Documentation
Blog
Changelog
Marketplace
View all features
Solutions
BY COMPANY SIZE
Enterprises
Small and medium teams
Startups
Nonprofits
BY USE CASE
App Modernization
DevSecOps
DevOps
CI/CD
View all use cases
BY INDUSTRY
Healthcare
Financial services
Manufacturing
Government
See all industries
View all solutions
Resources
EXPLORE BY TOPIC
AI
Software Development
DevOps
Security
View all topics
EXPLORE BY TYPE
Customer stories
Events & webinars
Ebooks & reports
Business insights
GitHub Skills
SUPPORT & SERVICES
Documentation
Customer support
Community forum
Trust center
Partners
View all resources
Open Source
COMMUNITY
GitHub Sponsors
Fund open source developers
PROGRAMS
Security Lab
Maintainer Community
GitHub Stars
Archive Program
REPOSITORIES
Topics
Trending
Collections
Enterprise
ENTERPRISE SOLUTIONS
Enterprise platform
AI-powered developer platform
AVAILABLE ADD-ONS
GitHub Advanced Security
Enterprise-grade security features
Copilot for Business
Enterprise-grade AI features
Premium Support
Enterprise-grade 24/7 support
Pricing
Search
/
Sign in
Sign up
Appearance settings
You signed in with another tab or window.
Reload
to refresh your session.
You signed out in another tab or window.
Reload
to refresh your session.
You switched accounts on another tab or window.
Reload
to refresh your session.
Dismiss alert
{{ message }}
coder
code-server
Repository navigation
Code
Issues
144
(144)
Pull requests
14
(14)
Discussions
Actions
Projects
Security and quality
1
(1)
Insights
More
items
fix(login): rate limiter shouldn't count successful logins
- #3141
#3141
Merged
repo-ranger[bot]
merged 14 commits into
main
coder/code-server:main
from
jsjoeio/fix-login-rate-limiter
coder/code-server:jsjoeio/fix-login-rate-limiter
Copy head branch name to clipboard
Apr 19, 2021
Conversation
Commits
14
(14)
Checks
Files changed
Merged
fix(login): rate limiter shouldn't count successful logins
#3141
repo-ranger[bot]
merged 14 commits into
main
coder/code-server:main
from
jsjoeio/fix-login-rate-limiter
coder/code-server:jsjoeio/fix-login-rate-limiter
Copy head branch name to clipboard
Commits
Commits on Apr 19, 2021
fix: update comment and export rateLimiter
jsjoeio
committed
4683d8a
View commit details
Copy full SHA for 4683d8a
Browse repository at this point
feat(testing): add tests for RateLimiter
jsjoeio
committed
58e17c5
View commit details
Copy full SHA for 58e17c5
Browse repository at this point
refactor(testing): combine loginPage with login
jsjoeio
committed
ebbabc6
View commit details
Copy full SHA for ebbabc6
Browse repository at this point
feat(testing): add e2e tests for password
jsjoeio
committed
faaa0a9
View commit details
Copy full SHA for faaa0a9
Browse repository at this point
feat: increase timeout for playwright tests
jsjoeio
committed
83cfbf8
View commit details
Copy full SHA for 83cfbf8
Browse repository at this point
refactor(login): move rate limiter after successful login
Show description for 0852107
jsjoeio
committed
0852107
View commit details
Copy full SHA for 0852107
Browse repository at this point
feat(testing): add test for rate limiter
jsjoeio
committed
1e6f4f2
View commit details
Copy full SHA for 1e6f4f2
Browse repository at this point
refactor: change config to save all e2e videos
jsjoeio
committed
a8719e1
View commit details
Copy full SHA for a8719e1
Browse repository at this point
refactor: update rateLimiter to check try
Show description for d8e4505
jsjoeio
committed
d8e4505
View commit details
Copy full SHA for d8e4505
Browse repository at this point
feat: add test for limiter.canTry()
jsjoeio
committed
7928dc2
View commit details
Copy full SHA for 7928dc2
Browse repository at this point
refactor: change limiter.Try() to .removeToken()
jsjoeio
committed
a3f18d6
View commit details
Copy full SHA for a3f18d6
Browse repository at this point
refactor: check errorMessage in login e2e test
jsjoeio
committed
958f012
View commit details
Copy full SHA for 958f012
Browse repository at this point
fix: update logic for removing token from limiter
jsjoeio
committed
7a50421
View commit details
Copy full SHA for 7a50421
Browse repository at this point
refactor: rateLimiter.canTry logic to check >= 1
jsjoeio
committed
f80d5c3
View commit details
Copy full SHA for f80d5c3
Browse repository at this point
You can’t perform that action at this time.