Skip to content

[Feat]: port proxy feature disable via cli option #5826

Open

Description

@Oliver-Weng-Sorcerer

Hi there,

can we add a cli option to disable the pop up on the lower right corner when web is served under a particular port ?

Or disable the whole "Ports" feature completely ?

currently the port proxy feature seems has some "relative path" issue if the code server is already behind a reverse proxy, so better to be disabled to avoid confusion.

Thanks

Screenshot 2022-11-21 at 11 27 43 AM

Screenshot 2022-11-21 at 11 28 06 AM

Activity

  1. changed the title [-][Feat]: [/-] [+][Feat]: port proxy feature disable via cli option[/+] on Dec 1, 2022
  2. Oliver-Weng-Sorcerer commented on Dec 1, 2022

    @Oliver-Weng-Sorcerer
    Author
  3. jsjoeio commented on Dec 1, 2022

    @jsjoeio
    Contributor

    Yes! Seems like we'd need to add a CLI flag and then use it here, with the default set to true https://github.com/coder/code-server/blob/main/patches/proxy-uri.diff#L178

  4. code-asher commented on Dec 5, 2022

    @code-asher
    Member

    Does disabling the "auto forward ports" option do anything?

  5. code-asher commented on Dec 5, 2022

    @code-asher
    Member

    Still might be a good idea to have a CLI flag to disable the proxy completely if needed for security reasons.

  6. Oliver-Weng-Sorcerer commented on Dec 5, 2022

    @Oliver-Weng-Sorcerer
    Author

    auto forward ports

    how to use "auto forward ports" option ? is it a cli option ?
    @code-asher

  7. jsjoeio commented on Dec 5, 2022

    @jsjoeio
    Contributor

    In your VS Code Settings:

    image

  8. Oliver-Weng-Sorcerer commented on Dec 5, 2022

    @Oliver-Weng-Sorcerer
    Author

    @jsjoeio thanks for the direction, I will test it out.

    but agreed, a cli option would be nicer to give user ability to turn it off on start

  9. Oliver-Weng-Sorcerer commented on Dec 23, 2022

    @Oliver-Weng-Sorcerer
    Author

    confirmed the auto forward ports option works.
    thanks @code-asher

  10. jsjoeio commented on Jan 3, 2023

    @jsjoeio
    Contributor

    Moving to Backlog for now. If more people want this, we can reconsider a CLI flag.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    enhancementSome improvement that isn't a feature

    Type

    No type

    Projects

    No projects

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions