Skip to content

[Helm chart] Typo in Helm chart notes #4504

Closed
#4515
Closed
[Helm chart] Typo in Helm chart notes#4504
#4515
Labels
waiting-for-infoWaiting for more information from submitter
Milestone
4.0.0 - pre-release

Description

@louis030195
louis030195
opened on Nov 13, 2021

In
https://github.com/cdr/code-server/blob/66060408354c223918cb1df4b0cb8849aad4c9c7/ci/helm-chart/templates/NOTES.txt#L20

you forgot the namespace, i.e. --namespace {{ .Release.Namespace }

Activity

  1. jsjoeio commented on Nov 15, 2021

    @jsjoeio
    jsjoeio
    on Nov 15, 2021
    Contributor

    Oh no! cc @jlandowner was this supposed to be updated in your PR? (I actually haven't touched the NOTES.txt so apologies if I missed in my review)

  2. jsjoeio
    added
    waiting-for-infoWaiting for more information from submitter
    on Nov 15, 2021

  3. jlandowner commented on Nov 16, 2021

    @jlandowner
    jlandowner
    on Nov 16, 2021
    Contributor

    Do you mean #4497? It's not for NOTES.txt.
    This is another issue.

  4. jsjoeio
    added this to the 4.0.0 milestone on Nov 16, 2021
  5. jsjoeio
    closed this as completedin #4515on Nov 16, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    waiting-for-infoWaiting for more information from submitter

    Type

    No type

    Projects

    No projects

      Milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions