Skip to content

Regression - "editor.emptySelectionClipboard": true not working anymore #413

Closed
Closed
Regression - "editor.emptySelectionClipboard": true not working anymore#413
Labels
bugSomething isn't working

Description

@jrpub
jrpub
opened on Apr 3, 2019
  • code-server version: v1.408-vsc1.32.0
  • OS Version: Ubuntu 18.04

Description

Before the v1.408, ctrl+c ctrl+v on a line without selection worked well. This is no more the case with the v1.408-vsc1.32.0.

Steps to Reproduce

Ctrl+c + Ctrl+v on a line without a selection, using the default configuration or with the settings "editor.emptySelectionClipboard": true

Activity

  1. jrpub
    added
    bugSomething isn't working
    on Apr 3, 2019

  2. RyanK1m commented on Apr 4, 2019

    @RyanK1m
    RyanK1m
    on Apr 4, 2019

    I think this issue causes #376

  3. RyanK1m commented on Apr 4, 2019

    @RyanK1m
    RyanK1m
    on Apr 4, 2019

    Remove these changes make this work again.
    scripts/vscode.patch file

    @@ -364 +363 @@ export class Configuration extends CommonEditorConfiguration {
-			emptySelectionClipboard: browser.isWebKit || browser.isFirefox,
+			emptySelectionClipboard: false, // browser.isWebKit || browser.isFirefox,

  4. sr229 commented on Sep 12, 2019

    @sr229
    sr229
    on Sep 12, 2019
    Contributor

    Already fixed this in latest tree. Closing this off.

  5. sr229
    closed this as completedon Sep 12, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    bugSomething isn't working

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions