Repository navigation
settings.json in code server v3.6.2 and v3.6.1 is no longer populated. #2274
Description
- Web Browser: Chrome latest
- Local OS: Mac latest
- Remote OS: Linux
- Remote Architecture: google cloud vm
code-server --version: 3.6.2 and 3.6.1
Recently upgraded to v3.6.2.
one thing seems a bit odd is that the settings.json was supposed to be populated under this directory: ~/.local/share/code-server/User if user has any vscode related settings change like a color theme.
the settings.json file was there in~/.local/share/code-server/User under v3.6.0
but the same settings.json can't be found in the same directory under v3.6.1 or v3.6.2
We are using the settings.json to control the default looking feel of the vscode, so this part is broken when upgrading to the latest.
Activity
Oliver-Weng-Sorcerer commentedon Nov 4, 2020
discuss with @code-asher ,
it seems vscode starting to read/set settings.json by using browser storage instead of on a remote disk.
wondering if anyone come across the same situation that needs to set default view when cod-server starts for the first time.
[-]settings.json in code server v3.6.2 is no longer populated.[/-][+]settings.json in code server v3.6.2 and v3.6.1 is no longer populated.[/+]code-asher commentedon Nov 4, 2020
I'm not aware of a way to do this but I think maybe what we do is patch VS Code to use the filesystem again. #2231 (comment)
Oliver-Weng-Sorcerer commentedon Nov 4, 2020
awesome, thanks for letting me know, will keep an eye on the release log in the future about this change.
Thank you. @code-asher you are amazing!
benz0li commentedon Nov 5, 2020
Thanks for your investigations, @code-asher.
I create customised Docker Images containing code-server and pre-populate
~/.local/share/code-server/User/settings.json. Using the filesystem again covers this use case, too.Keep up the great work on code-server!
demyxco commentedon Nov 12, 2020
Any news on this? I'm using a custom path for user data directory and just read this #2231. Placing a pre-populated settings.json isn't working.
code-asher commentedon Nov 12, 2020
cfal commentedon Nov 13, 2020
The settings.json local to code-server (~/.local/share/code-server/User/settings.json) still seem to work and can be accessed from "Open Remote Settings" inside vscode, but I believe the settings.json stored in the browser's local storage has priority and will override anything you set there.
demyxco commentedon Nov 14, 2020
Yeah looks like I'll have to update all my code-server repos and hardcode it to
3.6.0until this is resolved.hgw77 commentedon Nov 20, 2020
I have a settings.json that I place into my container to restore my User-Settings and with 3.7.2 the problem still exist.
have to downgrade to 3.6.0
gsmachado commentedon Nov 20, 2020
I can also confirm that the problem still exists with
3.7.2.As a consequence, it's not possible, at all, to set a custom
settings.jsonfile that "persists" and that code-server picks it. 😞Use file system for settings and fix data home path
Leletir commentedon Nov 23, 2020
Hello,
First of all, thank you for your work, is more than appreciated !
Do you have any news about this bug ?
code-asher commentedon Nov 23, 2020
nhooyr commentedon Nov 23, 2020
Will be in
v3.7.3which I'll get out today!gsmachado commentedon Nov 23, 2020
@nhooyr Great stuff! Much appreciated!
Looking forward to test
v3.7.3!Leletir commentedon Nov 23, 2020
Thank you very much!
demyxco commentedon Nov 24, 2020
v3.7.3works 👍sync with upstream (#1)
Delete local storage patch