Code-server can not install as desktop PWA in current version #1181

Activity

1. tgly307

   added

   bugSomething isn't workingSomething isn't working

   on Nov 16, 2019
2. sr229 commented on Nov 17, 2019

   

   sr229

   on Nov 17, 2019

   Contributor

   More actions

   Unfortunately, this is a upstream issue, which we cannot solve by our own. If you think this also has the same behavior with VS Online, open an issue in Microsoft/vscode as well.
3. sr229

   closed this as completedon Nov 17, 2019
4. geiseri commented on Feb 13, 2020

   

   geiseri

   on Feb 13, 2020

   Contributor

   More actions

   Can you reference where this is upstream? As far as I can tell it is an issue of a malformed manifest.

   {
   	"name": "code-server",
   	"short_name": "code-server",
   	"start_url": ".",
   	"display": "standalone",
   	"background-color": "#fff",
   	"description": "Run VS Code on a remote server.",
   	"icons": [{
   		"src": "./code-server.png",
   		"sizes": "384x384",
   		"type": "image/png"
   	}]
   }
   

   My command to start it is: code-server --host=0.0.0.0 --auth=none --port=8080 --base-path=/code I am behind a reverse proxy then that will forward https://gateway.foo.com/code to the local docker on port 8080.

   When I open the link the first thing is see is that the icon for code-server.png is not valid because it is looking for https://gateway.foo.com/code-server.png instead of https://gateway.foo.com/code/code-server.png. In general, it looks like some of the earlier calls go to https://gateway.foo.com and not https://gateway.foo.com/code, but somehow the server still replies so it works, but it might confuse the workers.

   Is the upstream bug in loader.js? As far as I can tell that is what registers the service workers. It loads from / first and then later it will use the correct base path.
5. code-asher commented on Feb 18, 2020

   

   code-asher

   on Feb 18, 2020 via email

   Member

   More actions

   Interesting, since the start URL is "." and you visit /code, that resolves to /code-server.png. If you visited /code/ (trailing slash), it would resolve to /code/code-server.png. I think what we'll need to do is inject the base path into the manifest before serving it.
6. nhooyr

   reopened this on Feb 18, 2020
7. code-asher

   added 2 commits that reference this issue on Feb 18, 2020

   Inject base path into manifest

   ...

   This issue will close once commit 597f7c0 is merged into the 'main' branch.

   597f7c0

   Inject base path into manifest

   ...

   This issue will close once commit d47591e is merged into the 'main' branch.

   d47591e
8. code-asher

   added a commit that references this issue on Feb 27, 2020

   Register a service worker

   ...

   This issue will close once commit 963ebac is merged into the 'main' branch.

   963ebac
9. code-asher

   closed this as completedin d47591eon Mar 3, 2020