You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
feat: -f/--format flag with strict msgpack rejection #30
Type: feat · Branch:feat/issue-30-format-flag · Part of epic #26
Problem
The CLI contract lists -f/--format and mandates a non-zero error on the unimplemented msgpack value rather than a silent fallback (cli-contract.md:12,44-58). No such flag exists (src/cli.ts, src/options/options.ts), so the facade can neither pass a default -f json uniformly nor get a clean msgpack rejection.
Change
Add -f, --format <json|msgpack> (default json), mirroring the strict-validation pattern already at src/cli.ts:78-99; msgpack/unknown → non-zero error (error: msgpack output is not yet implemented; use --format json). Add format to AnalysisOptions (default "json").
Acceptance
--format msgpack (and any unknown value) exits non-zero; --format json and omission succeed.
Covered in the flag-validation suite (pattern: test/dataflow.test.ts:396-425).
Dropped per maintainer decision: msgpack output has no consumers, and json is already the sole/default output — so a -f/--format flag (which existed only to expose json|msgpack and reject the unimplemented msgpack) is vestigial. The commit was rebased out of the stack; PR #39 (#31) now bases directly on #29 (#28).
Activity
rahlk commentedon Jul 7, 2026
Dropped per maintainer decision: msgpack output has no consumers, and json is already the sole/default output — so a
-f/--formatflag (which existed only to expose json|msgpack and reject the unimplemented msgpack) is vestigial. The commit was rebased out of the stack; PR #39 (#31) now bases directly on #29 (#28).