Repository navigation
Publish workspace ranges as real versions - #7
Merged
Merged
Conversation
added 2 commits
October 9, 2026 09:03
0.4.0 shipped the optional @codelitdev/billing peer as workspace:*, which npm refuses to install. Declare it as >=0.4.0 like the other internal peers. Also syncs bun.lock with the 0.4.0 package versions.
changeset publish runs npm publish, which copies workspace: ranges into the published package.json unchanged. Rewrite them to real versions on CI's checkout first. Workspace patterns the script cannot expand throw instead of skipping packages.
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 3966b680dc
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
@codelitdev/platform@0.4.0was published with its optional@codelitdev/billingpeer set toworkspace:*.changeset publishrunsnpm publish, which copiesworkspace:ranges unchanged, so with npm:Bun installs it because it ignores the optional peer, and
bun pm packrewritesworkspace:ranges, which is why packed-tarball testing missed it.Changes
>=0.4.0, asmcp-server-kitandplatform-conformancealready do for their platform peer. A patch changeset releases 0.4.1.scripts/resolve-workspace-ranges.mjsruns inreleasebeforechangeset publish. It rewrites any remainingworkspace:ranges in public packages to real versions on CI's checkout. Today that only affects devDependencies. Workspace patterns it can't expand (anything other than literal folder names and*) make it fail instead of skipping packages.bun.locknow records the 0.4.0 package versions. The release commit didn't update it.Testing
format:check,verifyandtemplate:smokepass.workspace:*ranges were rewritten, and the private examples were left alone.examples/*/apps/*pattern was expanded correctly.**,?and@(a|b)patterns threw an error.