Repository navigation
[Allure report] For deleteSuccessful option set to true in stepByStepReport - passed test cases in Allure still have screenshots attached #1494
Description
What are you trying to achieve?
Only successful test cases should have screenshots attached in Allure report.
What do you get instead?
Every single test case and step (including passed) has a screenshot attached in Allure report.
Provide test source code if related
Details
- CodeceptJS version: 2.0.4
- NodeJS Version: docker
- Operating System: docker
- Protractor
- Configuration file:
plugins: {
screenshotOnFail: {
enabled: true,
fullPageScreenshots: false
},
allure: {
enabled: true
},
autoDelay: {
enabled: true,
delayBefore: 100,
delayAfter: 150
},
stepByStepReport: {
enabled: true,
}
},deleteSuccessful option set to true by default according to documentation
Activity
kobenguyent commentedon Feb 8, 2019
[-][Allure report] For deleteSuccessful option set to false in stepByStepReport - passed test cases in Allure still have screenshots attached[/-][+][Allure report] For deleteSuccessful option set to truein stepByStepReport - passed test cases in Allure still have screenshots attached[/+][-][Allure report] For deleteSuccessful option set to truein stepByStepReport - passed test cases in Allure still have screenshots attached[/-][+][Allure report] For deleteSuccessful option set to true in stepByStepReport - passed test cases in Allure still have screenshots attached[/+]AdamOakman commentedon Feb 8, 2019
@peterngtr Sorry. My bad. I corrected issue summary and description. I had "deleteSuccessful option set to true by default" on my mind because that's how this works I think. Passed test cases and steps inside Allure still have screenshots attached in this case.
kobenguyent commentedon Feb 8, 2019
So I think currenty, either test passed or failed when you have allure with stepByStep enabled, screenshots are always attached to allure. :)
AdamOakman commentedon Feb 8, 2019
That's how it is! Shouldn't we make them attached for passed tests only? if below configuration happens
stepByStepReport: { deleteSuccessful: true, enabled: true }kobenguyent commentedon Feb 8, 2019
That combination, I guess yes, a PR is always welcome. :)
kobenguyent commentedon Feb 9, 2019
@AdamOakman so,
screenshotOnFailis enabled by default, you don't need to add this in your config.also, I pushed a PR to handle this nicely. More details you can find it here #1496
AdamOakman commentedon Feb 14, 2019
Thank you @peterngtr