ToDo #1

Activity

1. burdoto

   added

   enhancementNew feature or requestNew feature or request

   on Oct 13, 2019
2. burdoto

   self-assigned this

   on Oct 13, 2019
3. burdoto

   pinned this issue on Oct 13, 2019
4. burdoto commented on Oct 13, 2019

   

   burdoto

   on Oct 13, 2019

   ContributorAuthor

   More actions

   Something isn't right with Revisions: https://hastebin.com/iricudefag.rb
5. MicroDroid commented on Oct 14, 2019

   

   MicroDroid

   on Oct 14, 2019

   Member

   More actions

   My curl says your code is broken not mine

   👍React with 👍1Reacted by Kaley
6. burdoto commented on Oct 14, 2019

   

   burdoto

   on Oct 14, 2019

   Last edited by burdoto

   ContributorAuthor

   More actions

   This line being in the catch block breaks the Revision serialization:
   

   codebottle-java/src/main/java/io/codebottle/api/model/Snippet.java

   Line 159 in 08d4943

   while (i < data.size()) {

   This change fixed the Revision problem: 7429eb0
7. burdoto commented on Oct 14, 2019

   

   burdoto

   on Oct 14, 2019

   Last edited by burdoto

   ContributorAuthor

   More actions

   #getByID methods don't have side effects and should not be wrapped using synchronized

   codebottle-java/src/main/java/io/codebottle/api/CodeBottle.java

   Line 44 in 809ca06

   synchronized (languageCache) {
8. burdoto

   changed the title [-]ToDo List[/-] [+]ToDo[/+] on Oct 14, 2019
9. burdoto commented on Oct 14, 2019

   

   burdoto

   on Oct 14, 2019

   ContributorAuthor

   More actions

   Any response code should be expectable

   codebottle-java/src/main/java/io/codebottle/api/rest/CodeBottleRequest.java

   Line 86 in 809ca06

   if (HTTPCodes.getName(responseCode) == null)
10. burdoto commented on Oct 14, 2019

    

    burdoto

    on Oct 14, 2019

    ContributorAuthor

    More actions

    The used OkHttpClient should be alterable from the context

    codebottle-java/src/main/java/io/codebottle/api/rest/CodeBottleRequest.java

    Line 54 in 809ca06

    httpClient = new OkHttpClient.Builder()
11. burdoto

    closed this as completedin 5888794on Oct 14, 2019
12. burdoto

    reopened this on Oct 14, 2019
13. burdoto

    added 2 commits that reference this issue on Oct 14, 2019

    Allowed every code to be requestable

    ...

    71916a1

    Enabled httpClient replacement

    ...

    9ae198d