Repository navigation
feat(models): add report filename option - #174
Merged
Merged
Conversation
BioPhoton
added
➕ enhancement
matejchalk
requested changes
Oct 29, 2023
Co-authored-by: Matěj Chalk <34691111+matejchalk@users.noreply.github.com>
Co-authored-by: Matěj Chalk <34691111+matejchalk@users.noreply.github.com>
Co-authored-by: Matěj Chalk <34691111+matejchalk@users.noreply.github.com>
Co-authored-by: Matěj Chalk <34691111+matejchalk@users.noreply.github.com>
Co-authored-by: Matěj Chalk <34691111+matejchalk@users.noreply.github.com>
matejchalk
reviewed
Oct 30, 2023
matejchalk
left a comment
matejchalk
left a comment
Collaborator
There was a problem hiding this comment.
It works nicely with the config 👍
The PR description is a bit misleading, --filename (or --persist.filename) doesn't work as a CLI argument. You'd have to add persist.filename to core-config-options.ts to make it accessible from the CLI (we should auto-sync those in the future, probably).
Also, I noticed the PR title doesn't follow our commit conventions - model scope should be models.
matejchalk
previously approved these changes
Oct 30, 2023
vmasek
previously approved these changes
Oct 30, 2023
BioPhoton
changed the title
BioPhoton
changed the title
matejchalk
approved these changes
Oct 30, 2023
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The changes should help to improve testing of report generation. ATM all tests write in the same folder and with the same file name. Adding a
filenameoption to core would improve the testing situation and is helpful in for integrations.This PR includes:
persistConfigSchemawithfilenameand a default valueImplementing the CLI option is resolved in a followup PR
closes #161