Repository navigation
refactor(amount-entry): make shared/amount-entry a KMP module - #1932
Merged
Merged
Conversation
github-actions
Bot
added
the
type: refactor
bmc08gt
added a commit
that referenced
this pull request
Nov 3, 2026
…ee-pane * origin/code/cash: (44 commits) refactor(chat-list): move the chat list into a KMP module and wire it into the desktop graph (#1950) build(deps): bump dev.zacsweers.metro from 1.4.5 to 1.5.1 (#1901) feat(flipcash): add return-payment contract scaffolding (#1949) refactor(chat-ui): make shared/chat-ui a KMP module (#1934) build(deps): bump com.google.firebase:firebase-bom from 34.19.0 to 35.1.0 (#1900) build(deps): bump io.ktor:ktor-network from 3.4.1 to 3.6.0 (#1909) build(deps): bump rinku from 1.6.0 to 1.9.0 (#1907) build(deps): bump androidx.webkit:webkit from 1.17.0 to 1.18.0 (#1906) build(deps): bump agp from 9.4.1 to 9.5.0 (#1905) build(deps): bump androidx-datastore from 1.2.1 to 1.3.0 (#1904) build(deps): bump compose-multiplatform from 1.12.1 to 1.12.2 (#1903) build(deps): bump com.google.android.gms:play-services-base (#1902) build(deps): bump okhttp from 5.5.0 to 5.5.1 (#1899) refactor(messenger): split ChatViewModel's reducer into per-area files (#1933) refactor(amount-entry): make shared/amount-entry a KMP module (#1932) fix(build): stop KMP host tests building release variants and debug manifests changing per commit (#1948) refactor(theme): collapse Avenir into one family with a real Medium face (#1947) perf: run independent hot-path calls concurrently (#1945) docs(claude): test gestures with device input and keep mode state at screen level (#1943) build: bump Flipcash to 2026.11.2 ... # Conflicts: # CLAUDE.md
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
:apps:flipcash:shared:amount-entrynow usesflipcash.kmp.app.library(android + jvm). Module path and package are unchanged, so consumers are untouched.AmountEntryAction,AmountEntryConfig,AmountEntryController,AmountEntryDelegate,AmountEntryHint,AmountEntryLabel,AmountEntryStyle.AmountEntryLabelnow namesPair<AnnotatedString, Map<String, InlineTextContent>>through a private-to-module alias, because theAnnotatedButtonLabelalias lives in:apps:flipcash:core's androidMain. The type is identical.AmountEntryScreenonly. It callsAmountWithKeypad,CodeButtonandSlideToConfirm, which:apps:flipcash:core-uiand:ui:componentsstill declare in androidMain, so it has a// kmp-audit:line saying so. It can move once those do.AmountEntryDelegateTestandAmountEntryConfigTestmoved to commonTest and run on jvm and Android host (the delegate test swapsMainCoroutineRuleforDispatchers.setMain/resetMain).AmountEntryScreenTeststays in androidHostTest (Robolectric). 60 tests before; 60 on Android host and 49 on jvm after (the Robolectric screen test is Android-only).