Repository navigation
chore(analytics): create a funnel for phone number verification (entered, verified, linked) - #1076
Merged
Merged
Conversation
…red, verified, linked) Signed-off-by: Brandon McAnsh <git@bmcreations.dev>
github-actions
Bot
added
area: onboarding
type: chore
bmc08gt
added a commit
that referenced
this pull request
Jul 14, 2026
…iewModel tests The phone verification funnel analytics change (#1076) added a required `analytics: FlipcashAnalyticsService` constructor parameter to PhoneVerificationViewModel, but the unit tests were not updated, breaking compilation of :apps:flipcash:features:contact-verification:compileDebugUnitTestKotlin on code/cash. Pass a relaxed mock in both test factories.
bmc08gt
added a commit
that referenced
this pull request
Jul 14, 2026
…iewModel tests (#1079) The phone verification funnel analytics change (#1076) added a required `analytics: FlipcashAnalyticsService` constructor parameter to PhoneVerificationViewModel, but the unit tests were not updated, breaking compilation of :apps:flipcash:features:contact-verification:compileDebugUnitTestKotlin on code/cash. Pass a relaxed mock in both test factories.
bmc08gt
added a commit
that referenced
this pull request
Oct 16, 2026
… menu order The selection bar's Share to Chat… becomes Forward, and the separate Copy Message Link row goes: the sheet Forward opens already has a Copy Link tile. Actions now run Copy, Reply, Forward, Edit, Delete, Report, the order iOS #1076 uses.
bmc08gt
added a commit
that referenced
this pull request
Oct 16, 2026
… menu order The selection bar's Share to Chat… becomes Forward, and the separate Copy Message Link row goes: the sheet Forward opens already has a Copy Link tile. Actions now run Copy, Reply, Forward, Edit, Delete, Report, the order iOS #1076 uses.
bmc08gt
added a commit
that referenced
this pull request
Oct 16, 2026
… menu order The selection bar's Share to Chat… becomes Forward, and the separate Copy Message Link row goes: the sheet Forward opens already has a Copy Link tile. Actions now run Copy, Reply, Forward, Edit, Delete, Report, the order iOS #1076 uses.
bmc08gt
added a commit
that referenced
this pull request
Oct 16, 2026
* feat(messenger): share and copy a link to a message
Selecting a message now offers Share to Chat… and Copy Message Link
(overflow only). Both build app.flipcash.com/chat/{chatId}/m/{seq}
with Linkify.message: a UUID id for a group, base64url for a DM, which
the router reads back the same way.
Share to Chat opens the invite sheet with a Message subject; its Share
tile hands the bare URL to the system sheet. A new Link capability
gates both, kept for readers outside a group like Report.
* fix(messenger): name the message share action Forward and match iOS's menu order
The selection bar's Share to Chat… becomes Forward, and the separate
Copy Message Link row goes: the sheet Forward opens already has a Copy
Link tile. Actions now run Copy, Reply, Forward, Edit, Delete, Report,
the order iOS #1076 uses.
* fix(messenger): use filled icons in the message action bar
iOS moved its long-press menu to filled symbols (Copy, Reply, Forward,
Delete, Report). Edit stays the outline pencil on both, since SF Symbols
has no filled pencil.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.