Skip to content

Do not redirect the user when loading terms of service or privacy policy pages #1094

New issue
New issue
Closed
Closed
Do not redirect the user when loading terms of service or privacy policy pages#1094
Labels
Difficulty: EasySkill: Ember.jsSkill: JavaScriptSkill: Testingin progress
Milestone
Sign up when donating without being redirected

Description

@joshsmith
joshsmith
opened on Feb 23, 2017

Problem

Our onboarding flow right now redirects you from any route to the onboarding routes if you're in an onboarding state. This means that a user cannot access the terms of service or privacy policy when in this flow.

We should find a way to prevent these pages from ever redirecting on transition.

Activity

  1. begedin commented on Mar 20, 2017

    @begedin
    begedin
    on Mar 20, 2017
    Contributor

    Solution

    The process is happening in the application route:

    https://github.com/code-corps/code-corps-ember/blob/develop/app/routes/application.js#L226

    • Add list of excluded routes to the process of deciding if user should be redirected to onboarding
    • Add tos and privacy routes to that list
    • Add tests to ensure these routes are excluded from redirection
  2. begedin
    added
    Difficulty: Easy
    S
    on Mar 20, 2017
  3. joshsmith
    added
    Skill: Ember.js
    Skill: JavaScript
    Skill: Testing
    in progress
    on Mar 20, 2017
  4. joshsmith
    closed this as completedin #1189on Mar 27, 2017
  5. daveconnis
    added this to the Sign up when donating without being redirected milestone on Apr 3, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    Difficulty: EasySkill: Ember.jsSkill: JavaScriptSkill: Testingin progress

    Type

    No type

    Projects

    No projects

      Milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions