Skip to content

Fix seeds.exs to meet not null contraints - #316

Merged
joshsmith merged 1 commit into
code-corps:developfrom
fahrradflucht:fix-seed
Oct 4, 2016
Merged

joshsmith merged 1 commit into
code-corps:developfrom
fahrradflucht:fix-seed

Conversation

@fahrradflucht

Copy link
Copy Markdown
Contributor

5e6b235 introduced a not null constraint for the organization description.

This adds a description to the seeded org to meet that constraint.

While investigating this I noticed that the organization model doesn't require a description on the changeset. Is that intentional?

5e6b235 introduced a not null constraint for the organization description.

This adds a description to the seeded org to meet that constraint.
@joshsmith

Copy link
Copy Markdown
Contributor

the organization model doesn't require a description on the changeset

@fahrradflucht no, that's not intentional. Feel free to tackle that. Thanks for noticing!

@joshsmith joshsmith left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@joshsmith

Copy link
Copy Markdown
Contributor

Good catch. We also really need to add in some OrganizationMembership relationships and similar relationships, because those are currently missing. Leads to a lot of heartache.

Feel like there should be some easier ways to seed than what we're doing right now generally. All feels a bit hacky.

@joshsmith
joshsmith merged commit 8102acb into code-corps:develop Oct 4, 2016
@fahrradflucht
fahrradflucht deleted the fix-seed branch October 4, 2016 20:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants