Change the fields getter method to get -> opt of RepositoryApi  #43

Activity

1. sukeshni

   assigned

   sukeshni

   and

   fanwashere

   and unassigned

   sukeshni

   on May 22, 2015
2. shunjikonishi

   added this to the Sprint3This milestone has been deleted milestone on May 25, 2015
3. shunjikonishi commented on May 25, 2015

   

   shunjikonishi

   on May 25, 2015

   Contributor

   More actions

   @sukeshni @fanwashere
   How about this?
4. fanwashere commented on May 25, 2015

   

   fanwashere

   on May 25, 2015

   Contributor

   More actions

   @shunjikonishi I am finishing up Issues API. Right after I will double check and implement any missing fields for this issue.
5. fanwashere commented on May 26, 2015

   

   fanwashere

   on May 26, 2015

   Contributor

   More actions

   @sukeshni fix me. I looked at the response and added these fields in. This is not committed, you should add the fields in as you see fit.

   case class Repository(value: JValue) extends AbstractJson(value) {
     def id = get("id").toLong
     def name = get("name")
     def full_name = get("full_name")
   
     lazy val owner = User(value \ "owner")
   
     def `private` = boolean("private")
     def html_url = get("html_url")
     def description = opt("description")
     def fork = boolean("fork")
     def url = get("url")
     //Many types of urls here, I don't think is necessary
   
     def created_at = getDate("created_at")
     def updated_at = getDate("updated_at")
     def pushed_at = dateOpt("pushed_at") //Not sure if this could return null
   
     def homepage = opt("homepage")
     def size = get("size").toLong
     def stargazers_count = get("stargazers_count")
     def language = get("language")
     def has_issues = boolean("has_issues")
     def has_downloads = boolean("has_downloads")
     def has_wiki = boolean("has_wiki")
     def has_pages = boolean("has_pages")
     def forks_count = get("forks_count").toInt
     def mirror_url = opt("mirror_url")
     def open_issues_count = get("open_issues_count").toInt
     def forks = get("forks").toInt
     def open_issues = get("open_issues").toInt
     def watchers = get("watchers").toInt
     def default_branch = get("default_branch")
     def score = get("score").toLong
   
     lazy val permissions = Permissions(value \ "permissions")
   }

   There were a lot of url fields in between that may or may not be necessary. I have only tested a few of the fields so further testing is definitely required.

   Also, I did not noticed any response object called "permission", though I assume that is used in another operation.
6. sukeshni commented on May 26, 2015

   

   sukeshni

   on May 26, 2015

   ContributorAuthor

   More actions

   @fanwashere Thank you for your reply, will add the required fields. Object permission is not in the response, it is used by other operations.
7. fanwashere

   removed their assignment

   on Jun 19, 2015
8. takayukioda

   modified the milestone: Sprint3This milestone has been deleted on Mar 22, 2016