You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
I am working on cleaning up #36. I noticed the GitHub API has a commit search now. Did this capability exist 2 years ago when you were working on it? I'm wondering if it's worth implementing. Is it worth implementing?
@ashawley
We are using this library in our own production web service.
Now this API has enough features for our product.
Just now, we don't need any more features for our product.
Also, we are using this API in our internal helper tool GitHub-Hook.
This tool is very helpful for us. And if I have time, I want to add more features to this tool.
To improve that tool, I have to add some more features to this API. But I don't have enough time.
This is current status of this API.
About #36, I don't remember well. Probably it is better to discard once.
Are you using the Search API in your production web service? I assume you are not. I think you mean you are using other parts of this library in your production web service.
Activity
ashawley commentedon Jan 20, 2017
I am working on cleaning up #36. I noticed the GitHub API has a commit search now. Did this capability exist 2 years ago when you were working on it? I'm wondering if it's worth implementing. Is it worth implementing?
shunjikonishi commentedon Jan 20, 2017
@ashawley
We are using this library in our own production web service.
Now this API has enough features for our product.
Just now, we don't need any more features for our product.
Also, we are using this API in our internal helper tool GitHub-Hook.
This tool is very helpful for us. And if I have time, I want to add more features to this tool.
To improve that tool, I have to add some more features to this API. But I don't have enough time.
This is current status of this API.
About #36, I don't remember well. Probably it is better to discard once.
ashawley commentedon Jan 20, 2017
Are you using the Search API in your production web service? I assume you are not. I think you mean you are using other parts of this library in your production web service.
shunjikonishi commentedon Jan 20, 2017
We don't use search API now.
ashawley commentedon Jan 20, 2017
Ok. Cool.
Thanks for mentioning your Github-Hook project. I will look at it.
I really appreciate this library. It is a good library.
The Commit Search that I asked about before is new. It is only available as a preview. More information here at GitHub blog post https://developer.github.com/changes/2017-01-05-commit-search-api/ We sure don't need to implement it since it is so new.