Repository navigation
Define Eigen's MADD and ASSUME_ALIGNED macros for MSVC arm64 and UBSan - #490
Merged
Merged
Conversation
This was referenced Sep 20, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Avec MSVC arm64, Eigen n'active pas NEON et prend, pour les produits matriciels, un chemin qui suppose que le produit a le type de l'opérande de droite : les produits
Matrix×IntervalMatrixne compilaient pas. DéfinirEIGEN_HAS_SINGLE_INSTRUCTION_MADDfait prendre le cheminpmadddes autres architectures.Sous macOS/Clang,
EIGEN_ASSUME_ALIGNEDannonçait un alignement huit fois trop grand, que la libc++ vérifie sous-fsanitize=alignment: UBSan signalait chaque produit de matrices. Codac le remplace par une indication vide, sans changer les instructions choisies par Eigen.PR 18/64 de la série
dev-clean-v2(ordre et dépendances : #471). Indépendante : basée directement surcodac2, elle peut être mergée à tout moment.